-
-
Notifications
You must be signed in to change notification settings - Fork 96
feat: NeverNone to always generate an optional field, and AlwaysNone #677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
iloveitaly
wants to merge
4
commits into
litestar-org:main
Choose a base branch
from
iloveitaly:never-none
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -54,7 +54,7 @@ | |||||
) | ||||||
from polyfactory.exceptions import ConfigurationException, MissingBuildKwargException, ParameterException | ||||||
from polyfactory.field_meta import Null | ||||||
from polyfactory.fields import Fixture, Ignore, PostGenerated, Require, Use | ||||||
from polyfactory.fields import AlwaysNone, Fixture, Ignore, NeverNone, PostGenerated, Require, Use | ||||||
from polyfactory.utils.helpers import ( | ||||||
flatten_annotation, | ||||||
get_collection_type, | ||||||
|
@@ -334,6 +334,7 @@ def _handle_factory_field( # noqa: PLR0911 | |||||
if isinstance(field_value, Fixture): | ||||||
return field_value.to_value() | ||||||
|
||||||
# if a raw lambda is passed, invoke it | ||||||
if callable(field_value): | ||||||
return field_value() | ||||||
|
||||||
|
@@ -946,8 +947,16 @@ def should_set_none_value(cls, field_meta: FieldMeta) -> bool: | |||||
:returns: A boolean determining whether 'None' should be set for the given field_meta. | ||||||
|
||||||
""" | ||||||
field_value = hasattr(cls, field_meta.name) and getattr(cls, field_meta.name) | ||||||
never_none = field_value and isinstance(field_value, NeverNone) | ||||||
always_none = field_value and isinstance(field_value, AlwaysNone) | ||||||
|
||||||
if always_none: | ||||||
return True | ||||||
|
||||||
return ( | ||||||
cls.__allow_none_optionals__ | ||||||
and not never_none | ||||||
and is_optional(field_meta.annotation) | ||||||
and create_random_boolean(random=cls.__random__) | ||||||
) | ||||||
|
@@ -1021,13 +1030,16 @@ def _check_declared_fields_exist_in_model(cls) -> None: | |||||
f"{field_name} is declared on the factory {cls.__name__}" | ||||||
f" but it is not part of the model {cls.__model__.__name__}" | ||||||
) | ||||||
if isinstance(field_value, (Use, PostGenerated, Ignore, Require)): | ||||||
if isinstance(field_value, (Use, PostGenerated, Ignore, Require, NeverNone, AlwaysNone)): | ||||||
raise ConfigurationException(error_message) | ||||||
|
||||||
@classmethod | ||||||
def process_kwargs(cls, **kwargs: Any) -> dict[str, Any]: | ||||||
"""Process the given kwargs and generate values for the factory's model. | ||||||
|
||||||
If you need to deeply customize field values, you'll want to override this method. This is where values are | ||||||
generated and assigned for the fields on the model. | ||||||
|
||||||
:param kwargs: Any build kwargs. | ||||||
|
||||||
:returns: A dictionary of build results. | ||||||
|
@@ -1038,8 +1050,15 @@ def process_kwargs(cls, **kwargs: Any) -> dict[str, Any]: | |||||
for field_meta in cls.get_model_fields(): | ||||||
field_build_parameters = cls.extract_field_build_parameters(field_meta=field_meta, build_args=kwargs) | ||||||
if cls.should_set_field_value(field_meta, **kwargs) and not cls.should_use_default_value(field_meta): | ||||||
if hasattr(cls, field_meta.name) and not hasattr(BaseFactory, field_meta.name): | ||||||
field_value = getattr(cls, field_meta.name) | ||||||
has_field_value = hasattr(cls, field_meta.name) | ||||||
field_value = has_field_value and getattr(cls, field_meta.name) | ||||||
|
||||||
# NeverNone & AlwaysNone should be treated as a normally-generated field, since this changes logic | ||||||
# within get_field_value. | ||||||
excluded_field_value = has_field_value and isinstance(field_value, (NeverNone, AlwaysNone)) | ||||||
|
||||||
# TODO why do we need the BaseFactory check here, only dunder methods which are ignored would trigger this? # noqa: FIX002 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
or if fine to remove check then can do that |
||||||
if has_field_value and not hasattr(BaseFactory, field_meta.name) and not excluded_field_value: | ||||||
if isinstance(field_value, Ignore): | ||||||
continue | ||||||
|
||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,8 +22,24 @@ class Require: | |
"""A factory field that marks an attribute as a required build-time kwarg.""" | ||
|
||
|
||
class NeverNone: | ||
"""A factory field that marks as always generated, even if it's an optional.""" | ||
|
||
|
||
class AlwaysNone: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this required? Does from dataclasses import dataclass
from polyfactory.factories.dataclass_factory import DataclassFactory
@dataclass
class A:
a: int | None
class Factory(DataclassFactory[A]):
a = None
print(Factory.batch(size=10)) work for this use case? Could this be documented |
||
"""A factory field that marks as never generated, setting the value to None, regardless of if it's an optional field | ||
|
||
This is distinct from Ignore() which does not set a value for a field at all. If Ignore() is used and a default value | ||
for a field is not set on the underlying model, then the field will not be set at all. | ||
""" | ||
|
||
|
||
class Ignore: | ||
"""A factory field that marks an attribute as ignored.""" | ||
"""A factory field that marks an attribute as ignored. This prevents the factory generating any value for this field. | ||
|
||
If you are using this on a pydantic model this will cause the field to be omitted from the resulting pydantic model | ||
if there is no default value set for the pydantic field. | ||
""" | ||
|
||
|
||
class Use(Generic[P, T]): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
from typing import Optional | ||
|
||
from pydantic import BaseModel | ||
|
||
from polyfactory.factories.pydantic_factory import ModelFactory | ||
from polyfactory.fields import AlwaysNone, NeverNone | ||
|
||
|
||
def test_never_none() -> None: | ||
class MyModel(BaseModel): | ||
name: Optional[str] | ||
|
||
class MyFactory(ModelFactory[MyModel]): | ||
name = NeverNone() | ||
|
||
assert MyFactory.build().name is not None | ||
|
||
|
||
def test_always_none() -> None: | ||
class MyModel(BaseModel): | ||
name: Optional[str] | ||
|
||
class MyFactory(ModelFactory[MyModel]): | ||
name = AlwaysNone() | ||
# NOTE `name = None` does not end up | ||
|
||
# field is still accessible even though there is | ||
assert MyFactory.build().name is None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this applies to all callables rather than just lambdas. Can this be updated?