-
Notifications
You must be signed in to change notification settings - Fork 139
[CIR][ThroughMLIR] Add support for almabench
and fbench
from SingleSource test suite.
#1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2. Adds asin2 support
With this, both the tests pass.
Not sure if this enables some more test cases as well. |
almabench
and fbench
from SingleSource test suite.almabench
and fbench
from SingleSource test suite.
@@ -4802,6 +4803,7 @@ def FMinimumOp : BinaryFPToFPBuiltinOp<"fminimum", "MinimumOp">; | |||
def FModOp : BinaryFPToFPBuiltinOp<"fmod", "FRemOp">; | |||
def PowOp : BinaryFPToFPBuiltinOp<"pow", "PowOp">; | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for an extra newline here
@@ -293,6 +293,22 @@ class CIRUnaryMathOpLowering : public mlir::OpConversionPattern<CIROp> { | |||
} | |||
}; | |||
|
|||
class CIRATan2OpLowering : public mlir::OpConversionPattern<cir::ATan2Op> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While here, please add lowering and a test for direct LLVM lowering.
Thanks for working on this @goxul. Please change the title to be about the actual adding of ATan2, etc. You can add more information about the benchmarks in the description. Question: I wasn't expecting all these benchmarks to be working in the throughMLIR path, are you sure this is what you are running? Anyways, if direct LLVM also is missing this lowering, please go ahead and add it as part of this PR. |
From the SingleSource test suite,
almabench
had a missingATan2
implemention, whereasfbench
had missingasin
support. This PR adds support for both.