Use CXX_STANDARD 20 in all packages #401
Open
+103
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CXX_STANDARD 20 fails if rviz uses OGRE 1.10.11
```bash
ogre-1.10.11/include/OGRE/OgreMemorySTLAllocator.h:126:44: error: ‘const_pointer’ in ‘class std::allocator<void>’ does not name a type
126 | typename std::allocator<void>::const_pointer ptr = 0 )
| ^~~~~~~~~~~~~
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CXX_STANDARD 20in all packagesmaybe-uninitializedCXX_STANDARD 17for fuse_viz -CXX_STANDARD 20fails ifrvizuses OGRE 1.10.11We've bumped to C++20 standard in our fork clearpathrobotics#36
Sending this upstream in case you want to consider bumping to C++20 as well. Otherwise, feel free to close this PR.
I'm just trying to minimize the changes in our fork wrt upstream.