Skip to content

feat: add built-in model property types typdef #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

achrinza
Copy link
Member

@achrinza achrinza commented Sep 12, 2021

Added typdef for:

  • Any
  • JSON
  • Text
  • GeoPoint
  • DateString

Also see: microsoft/TypeScript#22865 (comment)

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@achrinza achrinza requested a review from dhmlau as a code owner September 12, 2021 09:34
@achrinza achrinza force-pushed the feat/ts-proprety-types branch 2 times, most recently from 7e1b3bf to c22adce Compare September 12, 2021 09:35
@coveralls
Copy link

coveralls commented Sep 12, 2021

Pull Request Test Coverage Report for Build 1226262292

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.763%

Totals Coverage Status
Change from base Build 1223745102: 0.01%
Covered Lines: 7124
Relevant Lines: 8106

💛 - Coveralls

Added typdef for:
- Any
- JSON
- Text
- GeoPoint
- DateString

Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza achrinza force-pushed the feat/ts-proprety-types branch from 7264db6 to 916f27a Compare September 22, 2021 11:19
@achrinza achrinza merged commit 816b948 into master Sep 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/ts-proprety-types branch September 22, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants