Skip to content

fix: ensure browser_snapshot correctly handles undefined arguments #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: ensure browser_snapshot correctly handles undefined arguments #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"license": "Apache-2.0",
"scripts": {
"build": "tsc",
"build": "npx tsc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"build": "npx tsc",
"build": "tsc",

I don't think thats right, if you run npm install it will put tsc into the node_modules directory and add it to PATH as soon as you run a package.json script.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're Probably right.

The main issue I found was the inability to handle empty args for the snapshot.

That seemed to break this MCP server for both Cursor and Windsurf at least in each environment I tested.

This seems like a large proportion of potential users for this, so rather than just complain with an issue report, I figured I'd share the fix I implemented and have found to work.

The other change wasn't necessary and I shouldn't have included it, so that's on me.

Let me know if you'd like me to adjust do anything to address this.

This MCP server is fantastic, btw.

"lint": "npm run update-readme && eslint . && tsc --noEmit",
"update-readme": "node utils/update-readme.js",
"watch": "tsc --watch",
Expand Down
3 changes: 2 additions & 1 deletion src/context.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ export class Context {

async run(tool: Tool, params: Record<string, unknown> | undefined) {
// Tab management is done outside of the action() call.
const toolResult = await tool.handle(this, tool.schema.inputSchema.parse(params));
const parsedParams = tool.schema.inputSchema.parse(params === undefined ? {} : params);
const toolResult = await tool.handle(this, parsedParams);
const { code, action, waitForNetwork, captureSnapshot, resultOverride } = toolResult;
const racingAction = action ? () => this._raceAgainstModalDialogs(action) : undefined;

Expand Down