Add workflow for running ScriptAnalyzer #236464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
microsoft-github-policy-service
bot
added
the
Needs-Attention
2 tasks
denelon
approved these changes
Mar 10, 2025
microsoft-github-policy-service
bot
added
the
Moderator-Approved
microsoft-github-policy-service
bot
removed
the
Needs-Attention
mdanish-kh
reviewed
Mar 10, 2025
| } | ||
|
|
||
| # If errors are found, exit with a non-zero exit code to fail the job | ||
| if ($results.where({$_.Severity-eq 'Error'})) { |
There was a problem hiding this comment.
Suggested change
| if ($results.where({$_.Severity-eq 'Error'})) { | |
| if ($results.where({$_.Severity -eq 'Error'})) { |
nit: style
|
didn't see denelon had merged it lol |
2 tasks
|
Fixed in latest PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for Pull Requests
PSScriptAnalyzerat PR level for.ps1files #236267This PR makes it so ScriptAnalyzer errors are identified by a workflow. Warnings and Informational items are still output in the workflow logs, but are non-blocking. This workflow should only trigger when a PowerShell script is added or modified
Once added, the repository rules should make this a required check
cc @denelon / @mdanish-kh / @stephengillie
Microsoft Reviewers: Open in CodeFlow