Skip to content

ROS Parameter for service call timeout for ros_control controllers (backport #3419) #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 12, 2025

Description

Added a new ROS parameter controller_service_call_timeout for the ROS control interface managers, which can be specified in the moveit_controller yaml configuration file. I have tested it out using the https://github.com/moveit/moveit_resources/tree/ros2/dual_arm_panda_moveit_config example moveit configuration by trying out the following values for the parameter in the moveit_controllers.yaml:

controller_service_call_timeout: 0.00001 : Controllers did not connect
controller_service_call_timeout: 1.0 : Controllers connected and path planning could be executed

Closes issue #3405

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3419 done by [Mergify](https://mergify.com).

…3419)

(cherry picked from commit 64e934f)

# Conflicts:
#	moveit_plugins/moveit_ros_control_interface/README.md
#	moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp
@mergify mergify bot added the conflicts label Apr 12, 2025
Copy link
Author

mergify bot commented Apr 12, 2025

Cherry-pick of 64e934f has failed:

On branch mergify/bp/humble/pr-3419
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 64e934ff4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_plugins/moveit_ros_control_interface/README.md
	both modified:   moveit_plugins/moveit_ros_control_interface/src/controller_manager_plugin.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@sea-bass
Copy link
Contributor

@ashwinsnambiar if you would like to resolve these conflicts for a Humble backport, it would be appreciated. It also doesn't really need a backport, though, so up to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants