Bug: user icons set from setup are lost after refresh

[dsaenztagarro]

First some words...

Hi, first of all, I appreciate a lot this open source plugin, and really, I'm super happy to have a chance to bring some gratitude for all the work from the NeoVim community. That said! Here is the issue...

Problem

I've realized that this plugin is not applying the icons set by the user by calling to setup function (e.g. icons set from overrides_by_extension.

I've done some investigation, and I have found that in #270 pull request, we introduced this auto command, in order to change icons depending on the background:

nvim-web-devicons/lua/nvim-web-devicons.lua

Lines 453 to 456 in 4c3a584

	-- Change icon set on background change
	vim.api.nvim_create_autocmd("OptionSet", {
	pattern = "background",
	callback = M.refresh,

From the issue description here, I read:

I have no config for nvim-web-devicons.

What it makes me think that the functionality was added without verifying that user overrides were kept.

It happens that NeoVim sets the background on startup automatically, as you can see in :help background

So just after all plugins are loaded with Lazy, the auto command is executed by NeoVim, loosing all user overrides.

As result, user icon overrides are not applied ever.

Requirement

Apply changes needed so user's icons overrides are kept on background changes (i.e. also applied just after opening NeoVim).

P.D: Hope all this makes sense to you 🙏

[alex-courtis]

Reopened following #575

[dsaenztagarro]

@alex-courtis just in case, adding a comment here, ready for you to review! Thanks in advance! 😅