Skip to content

SRVCOM-3676: Include OpenShift Serverless architecture diagram midstream #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

ochromy
Copy link
Contributor

@ochromy ochromy commented Apr 30, 2025

Issue link:

Motivation:

  • We don't have a proffesional diagram for the downstream docs yet.
    THEREFORE
  • We want to include the makeshift version in the midstream docs.

Contents:

  • A new assembly under the Serverless heading (serverless-architecture-diagram.adoc)
  • A new folder under serverless/assets/images containing the makeshift diagram in PNG format (serverless-architecture-diagram.png)

@openshift-ci-robot
Copy link

@ochromy: This pull request references SRVCOM-3676 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Issue link:

Motivation:

  • We don't have a proffesional diagram for the downstream docs yet.
    THEREFORE
  • We want to include the makeshift version in the midstream docs.

Contents:

  • A new assembly under the Serverless heading (serverless-architecture-diagram.adoc)
  • A new folder under serverless/assets/images containing the makeshift diagram in PNG format (serverless-architecture-diagram.png)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for jazzy-shortbread-5f62b7 ready!

Name Link
🔨 Latest commit b46a0c9
🔍 Latest deploy log https://app.netlify.com/sites/jazzy-shortbread-5f62b7/deploys/68186e3af74def0008cbc477
😎 Deploy Preview https://deploy-preview-125--jazzy-shortbread-5f62b7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@creydr
Copy link
Member

creydr commented May 2, 2025

@briandooley
Copy link

Works for me now, can you try again?
image

@creydr
Copy link
Member

creydr commented May 5, 2025

Sorry, I wasn't completely clear: clicking in the navigation on OpenShift Serverless architecture diagram doesn't change the site for me and does not show me an architecture diagram 🤔 (I am on Chrome)

Nav update

Nav update no2

Nav experiment no1

Nav experiment no2
@ochromy
Copy link
Contributor Author

ochromy commented May 5, 2025

Sorry, I wasn't completely clear: clicking in the navigation on OpenShift Serverless architecture diagram doesn't change the site for me and does not show me an architecture diagram 🤔 (I am on Chrome)

@creydr Apologies — I used the wrong xref format in nav.adoc. It should behave correctly now.

@creydr
Copy link
Member

creydr commented May 5, 2025

Now I can see it :)
Thanks for fixing @ochromy

@nainaz
Copy link

nainaz commented May 8, 2025

/LGTM

Copy link

openshift-ci bot commented May 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nainaz, ochromy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ochromy
Copy link
Contributor Author

ochromy commented May 14, 2025

Hi @creydr,
If everything looks good and you have merge permissions, could you please merge this — and also #121, if possible?
Thank you!

@creydr creydr merged commit ebe62bf into openshift-knative:master May 14, 2025
4 checks passed
@ochromy
Copy link
Contributor Author

ochromy commented May 14, 2025

@creydr Thanks!
Would you mind merging #121 as well, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants