feat: helper functions for verify_openvm_stark #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyunyunyunyu
requested review from
jonathanpwang and
yi-sun
and removed request for
yi-sun
This comment has been minimized.
This comment has been minimized.
nyunyunyunyu
force-pushed
the
feat/verify-vm-stark
branch
2 times, most recently
from
e539dd3 to
66d85df
Compare
nyunyunyunyu
force-pushed
the
feat/ux-improve-verify-stark
branch
from
2355c0c to
c43c618
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
… for verify_openvm_stark
nyunyunyunyu
force-pushed
the
feat/ux-improve-verify-stark
branch
from
395e9f3 to
492b2a2
Compare
This comment has been minimized.
This comment has been minimized.
jonathanpwang
approved these changes
May 15, 2025
Commit: 56e6d2e |
nyunyunyunyu
added a commit
that referenced
this pull request
May 15, 2025
- `AppExecutionCommit` stores `u32` instead of `BabyBear`. - Rename `E2eStarkProof` to `VmStarkProof`. - Add `compute_hint_key_for_verify_openvm_stark`/`encode_rv32_public_values` for users to prepare inputs for `verify_openvm_stark`. But it still seems hard to understand what happens. - Improve docs about `Rv32HintLoadByKey`.
jonathanpwang
pushed a commit
that referenced
this pull request
May 16, 2025
- `AppExecutionCommit` stores `u32` instead of `BabyBear`. - Rename `E2eStarkProof` to `VmStarkProof`. - Add `compute_hint_key_for_verify_openvm_stark`/`encode_rv32_public_values` for users to prepare inputs for `verify_openvm_stark`. But it still seems hard to understand what happens. - Improve docs about `Rv32HintLoadByKey`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppExecutionCommitstoresu32instead ofBabyBear.E2eStarkProoftoVmStarkProof.compute_hint_key_for_verify_openvm_stark/encode_rv32_public_valuesfor users to prepare inputs forverify_openvm_stark. But it still seems hard to understand what happens.Rv32HintLoadByKey.