-
Notifications
You must be signed in to change notification settings - Fork 58
feat: Add primitive guest libraries #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add primitive guest libraries #1642
Conversation
This comment has been minimized.
This comment has been minimized.
fabaddf
to
ccfcaf1
Compare
656670c
to
bea1fb1
Compare
bea1fb1
to
4357ece
Compare
0bff331
to
c3c3506
Compare
2a5f3c5
to
3e92415
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before anything else, as mentioned in Xinding's PR, I feel for guest-libs
the crate organization is unnecessarily complicated because it is a single rust library, not some collection like in VM extensions. Please follow the pattern in this PR: axiom-crypto/openvm-kzg#18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the best test now would be if you could patch k256
with openvm-k256
and see if ecrecover
from unpatched revm
still works
fef4b2a
to
3dcaa2a
Compare
This comment has been minimized.
This comment has been minimized.
6832602
to
be726c4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
use openvm::io::read_vec; | ||
use openvm_k256::Secp256k1Point; | ||
use openvm_k256::{Secp256k1, Secp256k1Point}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if you could just not have the openvm-k256
import at all here, and instead in Cargo.toml patch k256
with openvm-k256
? that's how we would likely use it in practice
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
64d99ed
to
1613445
Compare
This comment has been minimized.
This comment has been minimized.
ae9d4ab
to
1221bd5
Compare
This comment has been minimized.
This comment has been minimized.
1221bd5
to
0e45d8b
Compare
0e45d8b
to
3fd0a29
Compare
Commit: 3fd0a29 |
ea95b66
into
refactor/guest-library-reorg-final
No description provided.