Setup QEMU in build actions to check for build performance #288
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zohar7ch
changed the title
zohar7ch
force-pushed
the
zohar7ch/test-using-qemo
branch
from
2d77cb9 to
22cf8b6
Compare
orishoshan
reviewed
Apr 4, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM --platform=linux/amd64 golang:1.22.1-alpine AS buildenv | |||
| FROM golang:1.22.1-alpine AS buildenv | |||
There was a problem hiding this comment.
The build has to be native, the sniffer crashes if built with cross compilation
There was a problem hiding this comment.
Its ok, I was just testing to see whether this will improve the build time of the sniffer, and it didn't :(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the contributing guidelines for how to create and submit a high-quality PR for this repo. This template is based on Auth0's excellent template.
Description
Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.
Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.
References
Include any links supporting this change such as a:
If there are no references, simply delete this section.
Testing
Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.
Also include details of the environment this PR was developed in (language/platform/browser version).
Checklist