Skip to content

Setup QEMU in build actions to check for build performance #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Setup QEMU in build actions to check for build performance #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f74fa2
Setup QEMU in build actions to check for build performance
zohar7ch Apr 3, 2025
22cf8b6
Do not use specific platform in the sniffer Dockerfile
zohar7ch Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ jobs:
with:
submodules: recursive

- name: Set up QEMU for multi-platform builds
uses: docker/setup-qemu-action@v2

- name: Set up Docker Buildx
id: buildx
uses: docker/setup-buildx-action@master
Expand Down
2 changes: 1 addition & 1 deletion build/sniffer.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM --platform=linux/amd64 golang:1.22.1-alpine AS buildenv
FROM golang:1.22.1-alpine AS buildenv
RUN apk add --no-cache ca-certificates git protoc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build has to be native, the sniffer crashes if built with cross compilation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its ok, I was just testing to see whether this will improve the build time of the sniffer, and it didn't :(

RUN apk add build-base libpcap-dev
WORKDIR /src
Expand Down
Loading