Fix health check #39
Fix health check #39
Conversation
| @@ -33,6 +33,7 @@ jobs: | |||
| - name: Notify slack | |||
| uses: kpritam/slack-job-status-action@v1 | |||
| with: | |||
| if: ${{ failure() }} | |||
There was a problem hiding this comment.
@kleinjm I'm pretty sure that this will work fine with this and notify us of failure.
I would rather we trust the system and be notified only of failures in order to diminish noise.
There was a problem hiding this comment.
absolutely. And FWIW, that artifact upload GH action uses failure() and works as expected (doesn't try to upload on success case) so this should work
| job-status: ${{ job.status }} | ||
| slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }} | ||
| channel: github-actions |
There was a problem hiding this comment.
are you going to delete this channel? I'm in favor of that
.github/workflows/health_check.yml
Outdated
| node: ['10', '12', '14'] | ||
| node: ['12'] |
There was a problem hiding this comment.
not sure you want to do this if we care to support all versions. You can set max-parallel: 1 to run these in series instead of parallel and then we'll only be alerted on the first node version test suite that fails. See https://github.com/patch-technology/patch-ruby/blob/4c8f0f5fd64a46f4e4815764be3ffb677be425db/.github/workflows/test.yml#L16
There was a problem hiding this comment.
Good idea. I was concerned about getting four useless success notifications, but now that I've switched to failure only, this should work.
What
Why
SDK Release Checklist