Skip to content

Fix health check #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Fix health check #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c5d7aa
Fix health check
pcothenet Sep 1, 2021
b7e4c69
Failure only
pcothenet Sep 1, 2021
e31880d
Re-add all versions
pcothenet Sep 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/health_check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: ['10', '12', '14']
node: ['10','12','14','16']
max-parallel: 1
name: Node ${{ matrix.node }} Test
steps:
- name: Check out code
Expand All @@ -33,6 +34,7 @@ jobs:
- name: Notify slack
uses: kpritam/slack-job-status-action@v1
with:
if: ${{ failure() }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kleinjm I'm pretty sure that this will work fine with this and notify us of failure.

I would rather we trust the system and be notified only of failures in order to diminish noise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely. And FWIW, that artifact upload GH action uses failure() and works as expected (doesn't try to upload on success case) so this should work

job-status: ${{ job.status }}
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN }}
channel: github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you going to delete this channel? I'm in favor of that

channel: eng-notifications
4 changes: 4 additions & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,18 @@ jobs:
with:
node-version: 12
registry-url: https://registry.npmjs.org/

- name: Install dependencies
run: npm install

- name: Build package
run: npm run build

- name: Run tests
env:
SANDBOX_API_KEY: ${{ secrets.SANDBOX_API_KEY }}
run: npm test

- name: Publish package
run: npm publish --access public
env:
Expand Down
5 changes: 3 additions & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,10 @@ node_modules
# Optional REPL history
.node_repl_history

# OpenAPI Code gen artifacts
.openapi-generator/
# Ignore openapi-generator artifacts
.openapi-generator-ignore
/.openapi-generator/
git_push.sh

# OS artifacts
.DS_Store
Expand Down