Make link logging more consistent #10276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uranusjr I've made the changes as suggested |
pradyunsg
reviewed
Aug 6, 2021
AUTHORS.txt
Outdated
| @@ -631,3 +631,4 @@ Zvezdan Petkovic | |||
| Łukasz Langa | |||
| Семён Марьясин | |||
| rekcäH nitraM | |||
| Andrew Meleka | |||
There was a problem hiding this comment.
This file is auto-generated. Please don't edit it.
|
@pradyunsg can you please check? |
github-actions
bot
added
the
needs rebase or merge
|
Hmm... @andyalbert Could you update this PR? It currently has merge conflicts which means that the CI isn't able to run -- so I dunno how the tests react to this change. Overall though, I think it is worth improving how we present URLs! I wonder if we should present the full URL is verbose mode, and use show_url for non-verbose runs. That would be a slightly more complex patch than this. Would you be interested in exploring/implementing that? |
|
Closing this out given the lack of activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7390