Delay TempDirectory.delete resolution to cleanup

[uranusjr]

Quoting @chrahunt in #7571 (comment):

One issue with globally managing the temporary build directory is that InstallCommand and WheelCommand catch a PreviousBuildDirError and then explicitly set options.no_clean. This prevents us from taking a straightforward approach for configuring global tempdir handling if options.no_clean is set.

From my reading of the implementation, the problem is that the temp directory relies on the registry to decide whether it should clean up, but that decision is made on instantiation, so the PreviousBuildDirError handler cannot affect that decision. This patch would delay that decision until cleanup time instead, so the PreviousBuildDirError handler can be kept to tell the registry to stop the cleanup.

Feel free to close this if you think this is not the way to go.

[chrahunt]

I like this approach and I think it will let us solve the problem I mentioned in #7571 without making us depend on more refactoring to get rid of PreviousBuildDirError in order to move forward.

I would add a test for the new behavior in this PR.

We should also note that when this gets integrated with BaseCommand, we should add self.registry = self.enter_context(tempdir_registry()) before we initialize the global tmpdir manager here, otherwise the registry will get cleaned up before the temporary directories. This change will need more tests, so probably cleaner to do the change and tests in a separate PR.

[uranusjr]

Added a test, hope it makes sense.

[chrahunt]

This was a nice idea, thank you.