LAVA support along with test definitions comment fixes #14

vnarapar · 2025-05-12T05:29:47Z

Below are the changes merged as part of this PR

Added LAVA framework related changes and comment fixes as part of previous PR
find_test_case_by_name function modified
Added send-to-lava.sh along with SPDX license
Fixed indentation issues for all the scripts
removed source and added . in all the scripts
bash syntax is removed
Redundancy variables are removed in .yaml files

smuppand · 2025-05-12T05:44:37Z

@vnarapar Could you please add a Signed-off-by line to your commit message. This is required for DCO compliance.

Removed prev results Integrated LAVA framework with new YAML plans Added send-to-lava.sh script with SPDX license header Removed redundant variables in YAML files Integrated LAVA framework with new YAML plans Added send-to-lava.sh script with SPDX license header Removed redundant variables in YAML files Signed-off-by: Vamsee Narapareddi <[email protected]>

- Cleaned up bash syntax for better readability and maintainability Signed-off-by: Vamsee Narapareddi <[email protected]>

Modified the find command Signed-off-by: Vamsee Narapareddi <[email protected]>

Signed-off-by: Vamsee Narapareddi <[email protected]>

…tory Signed-off-by: smuppand <[email protected]> Signed-off-by: Vamsee Narapareddi <[email protected]>

Signed-off-by: Vamsee Narapareddi <[email protected]>

This pull request updates the project's license to BSD-3-Clause-Clear. Replaced the existing license file with the new license file. Reason for Change The update ensures that our project complies with the latest legal requirements and aligns with our current licensing strategy. Signed-off-by: smuppand <[email protected]> Signed-off-by: Vamsee Narapareddi <[email protected]>

Added functestlib.sh for IPA and RMNET Signed-off-by: Vamsee Narapareddi <[email protected]>

Integrated LAVA framework with new YAML plans Added send-to-lava.sh script with SPDX license header Removed redundant variables in YAML files Signed-off-by: Vamsee Narapareddi <[email protected]>

Replaced 'source' with '.' in all scripts for consistency Cleaned up bash syntax for better readability and maintainability Signed-off-by: Vamsee Narapareddi <[email protected]>

Modified the function find_test_case_by_name and run_specific_test_by_name in run-test.sh Signed-off-by: Vamsee Narapareddi <[email protected]>

I have fixed all the indentation issues in all shell scripts Signed-off-by: Vamsee Narapareddi <[email protected]>

made few changes for the script to work for sh, previously added to work with bash Signed-off-by: Vamsee Narapareddi <[email protected]>

Removed logging related functions as they are already present in functestlib.sh Signed-off-by: Vamsee Narapareddi <[email protected]>

Added functestlib.sh for IPA and RMNET as log_pass/log_fail are define there Signed-off-by: Vamsee Narapareddi <[email protected]>

Signed-off-by: Vamsee Narapareddi <[email protected]>

mwasilew

Commit message in "Modified the PASS/FAIL result in all the scripts to work for LAVA" is duplicated. Please leave just one copy.

There are 3 copies of some commits. Only one should remain.

Some commits are still missing the commit message.

I think this is a very good progress. Some minor cleanup is needed to merge this PR. If you need some help, ping my tomorrow and we can walk through the changes together.

mwasilew · 2025-05-12T18:55:38Z

Runner/plans/AudioCI_PreMerge.yaml

+run:
+    steps:
+        - cd Runner
+        - chmod -R 777 *


I think the steps are missing.

steps will be added once audio related testcases are merged

just remove it from the commit. No point carrying empty/broken test definition

mwasilew · 2025-05-12T18:56:55Z

Runner/suites/Kernel/FunctionalArea/baseport/GIC/run.sh

 	fi
+        echo "$TESTNAME PASS" > $test_path/$TESTNAME.res


I think some condition is missing here.

mwasilew · 2025-05-12T18:57:51Z

Runner/utils/send-to-lava.sh

@@ -0,0 +1,55 @@
+#Copyright: 2016-2019 Linaro Limited


2016-2025 for Linaro
I think we might add Qualcomm's copyright as well with date 2025

We generally shouldn't update or add Linaro's copyright statement (or any other 3rd parties). It looks like in this case the original file is unmarked: https://github.com/Linaro/test-definitions/blob/975b3d4bc03401ea9c5c6e078e1f3ac601561121/automated/utils/send-to-lava.sh#L4

In that case perhaps it is best to clearly reference in the file where it came from, the version used and the license. Plus include any relevant notices at the top level (e.g. info from https://github.com/Linaro/test-definitions/blob/975b3d4bc03401ea9c5c6e078e1f3ac601561121/COPYRIGHTS, etc...).

For example:

Script is from https://github.com/Linaro/test-definitions

SPDX-License-Identifier: GPL-2.0-only

We should only add our copyright if we have made modifications.

@craigez thanks for explanation. I thought this copyright applies to all files in the repository:
https://github.com/Linaro/test-definitions/blob/master/COPYRIGHTS

mwasilew · 2025-05-12T19:00:15Z

Runner/run-test.sh

@@ -8,8 +8,34 @@ source $TOOLS/functestlib.sh

 # Find test case path by name
 find_test_case_by_name() {
-    local test_name="$1"
-    find /var/Runner/suites -type d -iname "$test_name" 2>/dev/null
+    # local test_name="$1"


remove lines if they're not used.

mwasilew · 2025-05-12T19:00:48Z

Runner/run-test.sh

+      abs_path=$(readlink -f "$1")
+      echo "$abs_path"  
+      # Check if the run.sh file is present in the absolute path (ignoring case)
+      # if [ -f "$abs_path/run.sh" ]; then


Remove lines if they're not used.

mwasilew · 2025-05-12T19:03:33Z

Runner/suites/Kernel/FunctionalArea/baseport/CPUFreq_Validation/run.sh

-YELLOW="\e[33m"
-BLUE="\e[34m"
-NC="\e[0m" # No Color
+# Color codes (ANSI escape sequences)


I think we can leave it for now, but in the long run I would discourage from using colour output in test scripts.

mwasilew · 2025-05-14T09:17:59Z

This PR is replaced by #30.

vnarapar requested review from mwasilew and smuppand May 12, 2025 05:30

vnarapar force-pushed the main branch 6 times, most recently from e42aec1 to c62dba5 Compare May 12, 2025 17:39

vnarapar and others added 9 commits May 12, 2025 23:10

Replaced 'source' with '.' in all scripts for consistency

ab2c76a

- Cleaned up bash syntax for better readability and maintainability Signed-off-by: Vamsee Narapareddi <[email protected]>

Modified the find command to identify the testcase

dfe35e1

Modified the find command Signed-off-by: Vamsee Narapareddi <[email protected]>

Fixed indentation in all shell scripts

a752a9e

Signed-off-by: Vamsee Narapareddi <[email protected]>

CPU frequency changes to support sh

c8583eb

Signed-off-by: Vamsee Narapareddi <[email protected]>

Removing source files in preparation for migration to external reposi…

11301ab

…tory Signed-off-by: smuppand <[email protected]> Signed-off-by: Vamsee Narapareddi <[email protected]>

Removed unwanted functions from testcases

2138225

Signed-off-by: Vamsee Narapareddi <[email protected]>

Fixed rmnet and IPA script.

78db545

Added functestlib.sh for IPA and RMNET Signed-off-by: Vamsee Narapareddi <[email protected]>

vnarapar force-pushed the main branch from c62dba5 to 78db545 Compare May 12, 2025 17:40

vnarapar added 9 commits May 12, 2025 23:12

Added support for LAVA framework including YAML files

2105d0c

Integrated LAVA framework with new YAML plans Added send-to-lava.sh script with SPDX license header Removed redundant variables in YAML files Signed-off-by: Vamsee Narapareddi <[email protected]>

Replaced 'source' with '.' in all scripts for consistency

dfea5c2

Replaced 'source' with '.' in all scripts for consistency Cleaned up bash syntax for better readability and maintainability Signed-off-by: Vamsee Narapareddi <[email protected]>

Modified the find command to identify the testcase

4a49520

Modified the function find_test_case_by_name and run_specific_test_by_name in run-test.sh Signed-off-by: Vamsee Narapareddi <[email protected]>

Fixed indentation in all shell scripts

9238e04

I have fixed all the indentation issues in all shell scripts Signed-off-by: Vamsee Narapareddi <[email protected]>

CPU frequency changes to support sh

7acac23

made few changes for the script to work for sh, previously added to work with bash Signed-off-by: Vamsee Narapareddi <[email protected]>

Removed unwanted functions from testcases

619c57c

Removed logging related functions as they are already present in functestlib.sh Signed-off-by: Vamsee Narapareddi <[email protected]>

Fixed rmnet and IPA script.

0cb15c1

Added functestlib.sh for IPA and RMNET as log_pass/log_fail are define there Signed-off-by: Vamsee Narapareddi <[email protected]>

Removed source

6b5cb3c

Signed-off-by: Vamsee Narapareddi <[email protected]>

Fixed conflit

9a43d3a

Signed-off-by: Vamsee Narapareddi <[email protected]>

mwasilew requested changes May 12, 2025

View reviewed changes

smuppand mentioned this pull request May 14, 2025

Added support for LAVA framework including YAML files #30

Closed

mwasilew closed this May 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LAVA support along with test definitions comment fixes #14

LAVA support along with test definitions comment fixes #14

vnarapar commented May 12, 2025 •

edited

Loading

smuppand commented May 12, 2025

mwasilew left a comment

mwasilew May 12, 2025

vnarapar May 12, 2025

mwasilew May 12, 2025

vnarapar May 13, 2025

mwasilew May 12, 2025

mwasilew May 12, 2025

craigez May 14, 2025

mwasilew May 14, 2025

mwasilew May 12, 2025

mwasilew May 12, 2025

mwasilew May 12, 2025

mwasilew commented May 14, 2025

LAVA support along with test definitions comment fixes #14

LAVA support along with test definitions comment fixes #14

Conversation

vnarapar commented May 12, 2025 • edited Loading

smuppand commented May 12, 2025

mwasilew left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Script is from https://github.com/Linaro/test-definitions

SPDX-License-Identifier: GPL-2.0-only

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mwasilew commented May 14, 2025

vnarapar commented May 12, 2025 •

edited

Loading