Added support for LAVA framework including YAML files #30

vnarapar · 2025-05-14T07:02:59Z

Integrated LAVA framework with new YAML plans
Added send-to-lava.sh script with SPDX license header
Fixed indentation issues across all shell scripts
Replaced 'source' with '.' in all scripts for consistency
Removed redundant variables in YAML files
Cleaned up bash syntax for better readability and maintainability

smuppand · 2025-05-14T08:55:12Z

@vnarapar @mwasilew We can bypass this CR check failure (got confirmation from OSSOPS team too) and proceed with the merge if the changes look good. Please review the modifications and confirm if everything looks good.

mwasilew

@vnarapar feel free to remove my s-o-b from commits. I didn't do any work here. The signoffs are there after doing a cleanup and resolving conflicts. I leave the decision to you.

The commit messages still don't explain why changes are made. Please update it to reflect the reasons.

Please change the copyright on send-to-lava.sh as requested by @craigez

mwasilew · 2025-05-14T08:59:04Z

Runner/utils/send-to-lava.sh

@@ -0,0 +1,58 @@
+#Copyright: 2016-2019 Linaro Limited


As explained by Craig, this should go away and be replaced with URL to the original source

Can you please check if the below looks fine. so that i can add the same?

Upstream-Contact: Linaro validation mailing list [email protected]
Script is from https://github.com/Linaro/test-definitions
SPDX-License-Identifier: GPL-2.0-only

Also as requested removed your s-o-b and updated the commits on why they are made. Will update the license aswell if the above looks good.

@craigez could you comment on @vnarapar's proposal?

I think this is good for that file. We also should include the details in the LICENSE file too, so it appears at the top level and notice obligations can be met. There is where we can include Linaro copyrights from their project. Since they don't differentiate which copyright holders specifically contributed to this file, we might need to credit them all, for example:

Runner/utils/send-to-lava.sh: Script is from https://github.com/Linaro/test-definitions Copyright: 2012-2019 Linaro Limited 2019 Daniel Wagner <[email protected]> 2019 Daniel Wagner <[email protected]> 2019 Patryk Mungai <[email protected]> 2018 Karsten Tausche <[email protected]> 2018 Oleksandr Terentiev <[email protected]> 2017 Lei Yang <[email protected]> SPDX-License-Identifier: GPL-2.0-only

I also want to double check with @nbobbaqcom on some other requirements

@vnarapar @smuppand Please include a LICENSE file in the folder where this code is present.

@craigez @nbobbaqcom thanks for your help

Hi @mwasilew @nbobbaqcom @craigez

Added the license as suggested. please help review

Looks good to me.

smuppand · 2025-05-14T09:03:56Z

@vnarapar @mwasilew We can bypass this CR check failure (got confirmation from OSSOPS team too) and proceed with the merge if the changes look good. Please review the modifications and confirm if everything looks good.

Please check this explanation #14 (comment) and fix it.

mwasilew

Please change commit messages to use passive voice.

I'm not sure we need to include full GPL license in the LICENSE file. It can stay if it's a requirement.

Overall I think we're very close to merging this. There are only minor details left.

mwasilew · 2025-05-15T07:49:51Z

Runner/plans/KernelCI_PreMerge.yaml

+run:
+    steps:
+        - cd Runner
+        - chmod -R 777 *


this should not be here. Proper file permissions should be set in the repository.

removed the line and added permissions to the repository

mwasilew · 2025-05-15T07:50:09Z

Runner/plans/meta-qcom_PreMerge.yaml

+run:
+    steps:
+        - cd Runner
+        - chmod -R 777 *


This should not be here.

removed the line and added permissions to the repository

Runner/suites/Kernel/FunctionalArea/baseport/GIC/run.sh

mwasilew · 2025-05-15T07:51:51Z

Runner/suites/Kernel/FunctionalArea/baseport/Interrupts/run.sh

 	fi
+        echo "$TESTNAME PASS" > $test_path/$TESTNAME.res
+        echo "$TESTNAME FAIL" > $test_path/$TESTNAME.res


This looks wrong. The test will always fail. Is this expected?

This test will only fail if line#53 is executed which is the expectations as the condition is not met

Runner/suites/Kernel/FunctionalArea/baseport/Interrupts/run.sh

Runner/utils/functestlib.sh

mwasilew · 2025-05-15T07:58:55Z

Runner/suites/Kernel/FunctionalArea/baseport/CPUFreq_Validation/run.sh


 validate_cpu_core() {
-    local cpu=$1
-    local core_id=$2
+    cpu=$1


using local is indeed undefined in /bin/sh, but it's a common practice to use it as it helps defining variable scope. Maybe we should keep it.

Added local variables as suggested

mwasilew · 2025-05-15T08:01:18Z

Runner/suites/Kernel/FunctionalArea/baseport/CPUFreq_Validation/run.sh

    exit 1
+<<<<<<< HEAD


Please remove merge conflict marker and the remaining fi

It is removed as part of other commit

Runner/suites/Kernel/FunctionalArea/baseport/IPA/run.sh

mwasilew

You don't need 755 permissions on LICENSE or .yaml files.

Integrated LAVA framework with new YAML plans Added send-to-lava.sh script with SPDX license header Removed redundant variables in YAML files Removed Audio_Premerge yaml file Copied send-to-lava.sh from linaro to support result parsing with LAVA framework. Original source: https://github.com/Linaro/test-definitions/blob/master/automated/utils/send-to-lava.sh License: GPL-2.0-only, MIT This change is added for LAVA framework support to all the scripts based on testplan. Added the license file with 644 permissionsin the same folder where send-to-lava.sh is present as per review comment Removed chmod permissions in testplansand gave permissions to repository Signed-off-by: Vamsee Narapareddi <[email protected]>

Replaced 'source' with '.' in all scripts for consistency Cleaned up bash syntax for better readability and maintainability Signed-off-by: Vamsee Narapareddi <[email protected]>

Modified the function find_test_case_by_name and run_specific_test_by_name in run-test.sh to find the testcase to execute easily without depending on find command Removed unwanted lines from run-test.sh as it is dead code Signed-off-by: Vamsee Narapareddi <[email protected]>

Fixed all the indentation issues in all shell scripts for consistancy Signed-off-by: Vamsee Narapareddi <[email protected]>

Made few changes for the script to work for sh. The previous change works for bash. Hence modified to work with sh Added back local variables as per review comment Signed-off-by: Vamsee Narapareddi <[email protected]>

Removed logging related functions at testcase level since it is duplicate code and already present in functestlib.sh Added functestlib.sh for IPA and RMNET as logging related functions log_pass/log_fail are defined in functestlib.sh Signed-off-by: Vamsee Narapareddi <[email protected]>

Removed prev results Integrated LAVA framework with new YAML plans Added send-to-lava.sh script with SPDX license header Removed redundant variables in YAML files Integrated LAVA framework with new YAML plans Added send-to-lava.sh script with SPDX license header Removed redundant variables in YAML files This commit will remove few merge conflits Signed-off-by: Vamsee Narapareddi <[email protected]>

vnarapar · 2025-05-15T19:02:34Z

@mwasilew added 644 to License and 744 is required for yaml files to execute from LAVA

Merge PR #30 Signed-off-by: Milosz Wasilewski <[email protected]>

mwasilew · 2025-05-16T08:54:00Z

There was one more change I made manually to avoid extending this review. It's now merged to main branch. Closing this PR.

vnarapar requested review from mwasilew and smuppand May 14, 2025 07:02

mwasilew requested changes May 14, 2025

View reviewed changes

mwasilew mentioned this pull request May 14, 2025

LAVA support along with test definitions comment fixes #14

Closed

vnarapar force-pushed the LAVA branch 2 times, most recently from 0bd1ded to 1fec25f Compare May 15, 2025 07:40

mwasilew requested changes May 15, 2025

View reviewed changes

vnarapar force-pushed the LAVA branch 6 times, most recently from b462a14 to c627369 Compare May 15, 2025 18:33

vnarapar and others added 7 commits May 16, 2025 00:30

Replaced 'source' with '.' in all scripts for consistency

dfc0691

Replaced 'source' with '.' in all scripts for consistency Cleaned up bash syntax for better readability and maintainability Signed-off-by: Vamsee Narapareddi <[email protected]>

Fixed indentation in all shell scripts

473683d

Fixed all the indentation issues in all shell scripts for consistancy Signed-off-by: Vamsee Narapareddi <[email protected]>

CPU frequency changes to support sh

ae09370

Made few changes for the script to work for sh. The previous change works for bash. Hence modified to work with sh Added back local variables as per review comment Signed-off-by: Vamsee Narapareddi <[email protected]>

vnarapar force-pushed the LAVA branch from 00f1300 to 3119157 Compare May 15, 2025 19:01

mwasilew added a commit that referenced this pull request May 16, 2025

Merge branch 'vnarapar-LAVA'

73a2a03

Merge PR #30 Signed-off-by: Milosz Wasilewski <[email protected]>

mwasilew closed this May 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for LAVA framework including YAML files #30

Added support for LAVA framework including YAML files #30

vnarapar commented May 14, 2025

smuppand commented May 14, 2025

mwasilew left a comment

mwasilew May 14, 2025

vnarapar May 14, 2025

vnarapar May 14, 2025

mwasilew May 14, 2025

craigez May 14, 2025 •

edited

Loading

nbobbaqcom May 15, 2025 •

edited

Loading

mwasilew May 15, 2025

vnarapar May 15, 2025

nbobbaqcom May 15, 2025

smuppand commented May 14, 2025

mwasilew left a comment

mwasilew May 15, 2025

vnarapar May 15, 2025

mwasilew May 15, 2025

vnarapar May 15, 2025

mwasilew May 15, 2025

vnarapar May 15, 2025 •

edited

Loading

mwasilew May 15, 2025

vnarapar May 15, 2025

mwasilew May 15, 2025

vnarapar May 15, 2025

mwasilew left a comment

vnarapar commented May 15, 2025

mwasilew commented May 16, 2025

Added support for LAVA framework including YAML files #30

Added support for LAVA framework including YAML files #30

Conversation

vnarapar commented May 14, 2025

smuppand commented May 14, 2025

mwasilew left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

craigez May 14, 2025 • edited Loading

Choose a reason for hiding this comment

nbobbaqcom May 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smuppand commented May 14, 2025

mwasilew left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vnarapar May 15, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mwasilew left a comment

Choose a reason for hiding this comment

vnarapar commented May 15, 2025

mwasilew commented May 16, 2025

craigez May 14, 2025 •

edited

Loading

nbobbaqcom May 15, 2025 •

edited

Loading

vnarapar May 15, 2025 •

edited

Loading