-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Adafruit Fruit Jam board #2363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Adafruit Fruit Jam board #2363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hmmm, for the benefit of users of your new board, is it worth adding additional defines to your header for "3x tactile switches" etc. ? |
Yes, probably a good idea :) Done. |
7a51238
to
fe460bd
Compare
I see that https://www.adafruit.com/product/6200 currently says "we also need a name, right now we're just calling it Fruit Jam since its inspired by the IchigoJam project." - has the name now been finalised? Looks like a fun little board though 😃 |
I apologize for the churn here. It's been a bit of a moving target. Fruit Jam is going to be the name -- that copy hasn't been updated yet. There will also be a WiFi/BLE co-processor on the final board. We've got it running a bunch of emulators now, like C64, old Mac (HyperCard, anyone?) etc. |
Note 2.1.2 is approaching - so best to finalize this soon |
…o adafruit-fruit-jam
9017f79
to
4ede86c
Compare
@lurch This is ready for re-review. The board is in its final form now. Changes here reflect your suggestions from #2510 (another PR for this board that you reviewed and then we closed in favor of this one). I ran https://github.com/raspberrypi/pico-sdk/blob/master/tools/check_board_header.py and it does not complain. Thank you. One question: is Tagging @ladyada for reference. |
I'm afraid I don't know the answer to that, but @will-v-pi or @kilograham might know? |
Oh, I've also just remembered that there's a pico_audio library in pico-extras as well, so maybe you want to include some of the |
I added yet more pins for I2S. I started writing something about the limitations and implicitness of passing of pins and settings via macro names versus function call arguments, but this PR was not the place to discuss it. You can see how the API's from pico-extras, etc., are leaking into the board header files. Maybe I'll bring it up in the forums or in a pico-extras issue. |
206c948
to
453527f
Compare
Add Adafruit Fruit Jam "Mini RP2350 Computer" board. https://www.adafruit.com/product/6200. Description: