new board :) 🍍🍉🍇🍋🟩🍐 #2510
new board :) 🍍🍉🍇🍋🟩🍐 #2510
Conversation
|
I guess this supersedes #2363 ? |
| @@ -0,0 +1,121 @@ | |||
| /* | |||
| * Copyright (c) 2024 FRUITJAM Board | |||
There was a problem hiding this comment.
Presumably this should be a company-name, rather than a product-name? 🤔
| // SHOULD ONLY CONSIST OF PREPROCESSOR DIRECTIVES | ||
| // ----------------------------------------------------- | ||
|
|
||
| // This header may be included by other board headers as "boards/fruitjam.h" |
There was a problem hiding this comment.
This ought to be "boards/adafruit_fruitjam.h"
|
|
||
| // This header may be included by other board headers as "boards/fruitjam.h" | ||
|
|
||
| // pico_cmake_set PICO_PLATFORM=rp2350 |
There was a problem hiding this comment.
This should be replaced with the new-style
pico_board_cmake_set(PICO_PLATFORM, rp2350)
instead.
| #ifndef _BOARDS_FRUITJAM_H | ||
| #define _BOARDS_FRUITJAM_H |
There was a problem hiding this comment.
This ought to be _BOARDS_ADAFRUIT_FRUITJAM_H
| #define _BOARDS_FRUITJAM_H | ||
|
|
||
| // For board detection | ||
| #define FRUITJAM_BOARD |
There was a problem hiding this comment.
This ought to be ADAFRUIT_FRUITJAM
|
|
||
| // --- UART --- | ||
| #ifndef PICO_DEFAULT_UART | ||
| #define PICO_DEFAULT_UART 0 |
There was a problem hiding this comment.
GPIO 8 and 9 are UART1 TX and UART1 RX, so was this supposed to be #define PICO_DEFAULT_UART 1 ?
| #define PICO_DEFAULT_SPI_RX_PIN FRUITJAM_SD_DAT0_PIN | ||
| #endif | ||
| #ifndef PICO_DEFAULT_SPI_CSN_PIN | ||
| #define PICO_DEFAULT_SPI_CSN_PIN FRUITJAM_SD_CS_PIN |
There was a problem hiding this comment.
FRUITJAM_SD_CS_PIN is set to 39, but according to Table 3 in https://datasheets.raspberrypi.com/rp2350/rp2350-datasheet.pdf GPIO 39 is SPI0 TX. (If this is a software-controlled CS pin that's totally fine; but in that case you shouldn't define PICO_DEFAULT_SPI_CSN_PIN.)
| #define PICO_FLASH_SPI_CLKDIV 2 | ||
| #endif | ||
|
|
||
| // pico_cmake_set_default PICO_FLASH_SIZE_BYTES = (16 * 1024 * 1024) |
There was a problem hiding this comment.
This should be replaced with the new-style
pico_board_cmake_set_default(PICO_FLASH_SIZE_BYTES, (16 * 1024 * 1024))
| #endif | ||
|
|
||
| // --- RP2350 specific settings --- | ||
| // pico_cmake_set_default PICO_RP2350_A2_SUPPORTED = 1 |
There was a problem hiding this comment.
This should be replaced with the new-style
pico_board_cmake_set_default(PICO_RP2350_A2_SUPPORTED, 1)
|
This file is also missing a FYI these errors were all spotted by https://github.com/raspberrypi/pico-sdk/blob/develop/tools/check_board_header.py |
|
woops i didnt realize we had a draft, dan will update his draft and incorporate all notes :) |
* Adafruit Fruit Jam board * add Adafruit Fruit Jam specific pins * fix pin typos and errors * update to Fruit Jam rev D, address #2510 review * add additional PICO_DEFAULT_* pins * add PICO_AUDIO_I2S_* pins
This is a new board "Fruit Jam" from adafruit which will have some pico-sdk examples - unreleased but tested against rev C hardware