target/riscv: active dm before get nextdm #1252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lz-bro
force-pushed
the
active-dm-before-get-nextdm
branch
from
959583d to
8391810
Compare
Ubuntu 20.04 is no longer available. See actions/runner-images#11101 Checkpatch-ignore: BAD_SIGN_OFF Change-Id: I0ec3e3342f9212a2a79d8dca6274e7db62ecedab Signed-off-by: Evgeniy Naydanov <[email protected]>
lz-bro
force-pushed
the
active-dm-before-get-nextdm
branch
from
8391810 to
508ac6f
Compare
en-sc
previously approved these changes
May 7, 2025
src/target/riscv/riscv-013.c
Outdated
| break; | ||
|
|
||
| const time_t start = time(NULL); | ||
| LOG_TARGET_DEBUG(target, "Waiting for the DM to active."); |
There was a problem hiding this comment.
I'm not sure this is grammatically correct. I'd suggest:
Suggested change
| LOG_TARGET_DEBUG(target, "Waiting for the DM to active."); | |
| LOG_TARGET_DEBUG(target, "Waiting for the DM to activate."); |
or
Suggested change
| LOG_TARGET_DEBUG(target, "Waiting for the DM to active."); | |
| LOG_TARGET_DEBUG(target, "Waiting for the DM to become active."); |
src/target/riscv/riscv-013.c
Outdated
|
|
||
|
|
||
| } while (!get_field32(dmcontrol, DM_DMCONTROL_DMACTIVE)); | ||
| LOG_TARGET_DEBUG(target, "DM successfully active."); |
There was a problem hiding this comment.
Same as above. I'd suggest a simpler
Suggested change
| LOG_TARGET_DEBUG(target, "DM successfully active."); | |
| LOG_TARGET_DEBUG(target, "DM is active."); |
when Debug Module is inactive, accesses to the nextdm may fail. Specifically, nextdm might not return correct data.
lz-bro
force-pushed
the
active-dm-before-get-nextdm
branch
from
508ac6f to
3f14acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when Debug Module is inactive, accesses to the nextdm may fail. Specifically, nextdm might not return correct data.
When I want to debug a target form a specific DM, the config is as flows:
openocd can not get correct nextdm Due to DM with DMI base address = 0x0 is inactive.