Skip to content

Miscellaneous changes for RDF Snapshot test #19004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vepadulano
Copy link
Member

No description provided.

It seems to be working again on a MacOS laptopt with M3 chip, so we
should be able to add it back to the testing suite.
A test case with a TTree with variable sized arrays was always printing
to screen the entire content of the arrays, flooding the test output
even in the correct case. Since the arrays are quite long this is not
really helpful even in case of failure, we can rely on the output of the
gtest macro.
Copy link
Contributor

@martamaja10 martamaja10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vepadulano
Copy link
Member Author

Well, the dataframe_snapshot failure on Mac ARM64 is due to throwing an exception when JITting. The reason it worked on my laptop is because I'm testing on my branch with Snapshot that does not need JITting :) That will soon get its own PR, I guess at least we know it should improve also this one 👍

@vepadulano vepadulano marked this pull request as draft June 10, 2025 17:12
@vepadulano
Copy link
Member Author

#19006 is a requirement for this PR

Copy link

Test Results

    19 files      19 suites   3d 14h 10m 15s ⏱️
 2 808 tests  2 806 ✅ 0 💤 2 ❌
51 855 runs  51 851 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 1c336a7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants