Skip to content

Miscellaneous changes for RDF Snapshot test #19004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Miscellaneous changes for RDF Snapshot test #19004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b841241
[df] Add back Snapshot test to Mac ARM64
vepadulano Jun 10, 2025
1c336a7
[df] Avoid text flooding in test
vepadulano Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tree/dataframe/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ if(MSVC)
set_source_files_properties(dataframe_simple.cxx PROPERTIES COMPILE_FLAGS /bigobj)
endif()

if(NOT (MSVC OR (APPLE AND CMAKE_SYSTEM_PROCESSOR MATCHES arm64)) OR win_broken_tests OR M1_BROKEN_TESTS)
if(NOT MSVC OR win_broken_tests)
ROOT_ADD_GTEST(dataframe_snapshot dataframe_snapshot.cxx LIBRARIES ROOTDataFrame GenVector)
endif()

Expand Down
6 changes: 0 additions & 6 deletions tree/dataframe/test/dataframe_snapshot.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,18 +477,12 @@ void checkSnapshotArrayFile(RResultPtr<RInterface<RLoopManager>> &df, unsigned i
const auto &bv = varSizeBoolArr->at(i);
EXPECT_EQ(thisSize, dv.size());
EXPECT_EQ(thisSize, bv.size());
std::cout << "bv: ";
for (auto j = 0u; j < thisSize; ++j)
std::cout << bv[j] << ' ';
std::cout << "\nexpected: ";
for (auto j = 0u; j < thisSize; ++j) {
EXPECT_DOUBLE_EQ(dv[j], i * j);
const bool value = bv[j];
const bool expected = j % 2 == 0;
std::cout << expected << ' ';
EXPECT_EQ(value, expected);
}
std::cout << '\n';
}
}

Expand Down
Loading