-
Notifications
You must be signed in to change notification settings - Fork 81
Use new windows workflow #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 87.13% 87.14%
=======================================
Files 17 17
Lines 1290 1291 +1
Branches 105 105
=======================================
+ Hits 1124 1125 +1
Misses 97 97
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
saikishor
previously approved these changes
Jun 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great work as always
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
(cherry picked from commit 33a13d6) # Conflicts: # .github/workflows/humble-binary-build-win.yml
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
(cherry picked from commit 33a13d6)
christophfroehlich
added a commit
that referenced
this pull request
Jun 23, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Jun 23, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
backport-jazzy
This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs ros-controls/ros2_control_ci#374
This supports rolling only, so I removed windows workflows for distros other than rolling.