Skip to content

Use new windows workflow #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2025
Merged

Use new windows workflow #358

merged 7 commits into from
Jun 23, 2025

Conversation

christophfroehlich
Copy link
Contributor

Needs ros-controls/ros2_control_ci#374

This supports rolling only, so I removed windows workflows for distros other than rolling.

@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (c187106) to head (080b8f6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   87.13%   87.14%           
=======================================
  Files          17       17           
  Lines        1290     1291    +1     
  Branches      105      105           
=======================================
+ Hits         1124     1125    +1     
  Misses         97       97           
  Partials       69       69           
Flag Coverage Δ
unittests 87.14% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

saikishor
saikishor previously approved these changes Jun 15, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work as always

@christophfroehlich christophfroehlich merged commit 33a13d6 into master Jun 23, 2025
24 checks passed
@christophfroehlich christophfroehlich deleted the windows/pixi branch June 23, 2025 07:54
@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. labels Jun 23, 2025
mergify bot pushed a commit that referenced this pull request Jun 23, 2025
(cherry picked from commit 33a13d6)

# Conflicts:
#	.github/workflows/humble-binary-build-win.yml
mergify bot pushed a commit that referenced this pull request Jun 23, 2025
(cherry picked from commit 33a13d6)
christophfroehlich added a commit that referenced this pull request Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble. backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants