Use the embedded-hal::digital::v2::OutputPin traits #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
approved these changes
Jun 10, 2019
|
Released in 0.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an error
enumwith two types, a communication error type and a pin error type.Now users of this crate can handle I2C or SPI communication errors as well as SPI pin setting errors.
Nevertheless, it requires no changes in the user code if the results were only unwrapped like in the examples in this crate.
In order to keep the creation infallible, I moved the chip-select high setting from the
SpiInterface::newinto aDisplayInterface::init()method which will be called when the user callsdisplay.init().unwrap().SA: rust-embedded/embedded-hal#135