Use the embedded-hal::digital::v2::OutputPin #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamwaffles
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
Untested on real hardware as I don't have any to hand right now, but it all looks good to me.
@therealprof any reservations? Otherwise I'll merge this to master and do a semver-minor release 👌
|
Thanks @eldruin! I'll get this released when I'm next on a Linux machine. |
|
Released in 0.2.5. |
This was referenced Jul 1, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similarly to rust-embedded-community/sh1106#8, I added an error
enumwith two types: a communication error type and a pin error type which allows users to handle I2C or SPI communication errors as well as SPI pin setting errors.I had to make
resetfallible, though. User code will then get an unused Result warning.No other changes are required in user code if the results were simply unwrapped.