This repository was archived by the owner on Mar 14, 2023. It is now read-only.
Use warning emoji instead of external image #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good call, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some conditions (e.g., when submodules are modified, like here) Highfive posts warning messages. The beginning of the warning looks like this:
The warning icons in that message are an SVG from an external location (here). At this point, GitHub supports a diverse set of emoji, including a warning icon:⚠️ . This PR replaces the use of the external SVG with the emoji. This will be more future proof and it is generally nicer to use the built-in emoji, as long as you are all right with the color change. Here's how the beginning of the warning looks with the emoji:
