Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

Use warning emoji instead of external image #155

Merged
merged 1 commit into from
May 20, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion highfive/newpr.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def welcome_msg(reviewer, config):
link = "https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md"
return raw_welcome % (text, link)

warning_summary = '<img src="http://www.joshmatthews.net/warning.svg" alt="warning" height=20> **Warning** <img src="http://www.joshmatthews.net/warning.svg" alt="warning" height=20>\n\n%s'
warning_summary = ':warning: **Warning** :warning:\n\n%s'
unsafe_warning_msg = 'These commits modify **unsafe code**. Please review it carefully!'
submodule_warning_msg = 'These commits modify **submodules**.'
surprise_branch_warning = "Pull requests are usually filed against the %s branch for this repo, but this one is against %s. Please double check that you specified the right target!"
Expand Down
6 changes: 3 additions & 3 deletions highfive/tests/test_newpr.py
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ def test_unexpected_branch(self):
)
self.mocks['modifies_submodule'].assert_called_with(self.diff)

expected_warning = """<img src="http://www.joshmatthews.net/warning.svg" alt="warning" height=20> **Warning** <img src="http://www.joshmatthews.net/warning.svg" alt="warning" height=20>
expected_warning = """:warning: **Warning** :warning:

* Pull requests are usually filed against the master branch for this repo, but this one is against something-else. Please double check that you specified the right target!"""
self.mocks['post_comment'].assert_called_with(
Expand All @@ -692,7 +692,7 @@ def test_modifies_submodule(self):
)
self.mocks['modifies_submodule'].assert_called_with(self.diff)

expected_warning = """<img src="http://www.joshmatthews.net/warning.svg" alt="warning" height=20> **Warning** <img src="http://www.joshmatthews.net/warning.svg" alt="warning" height=20>
expected_warning = """:warning: **Warning** :warning:

* These commits modify **submodules**."""
self.mocks['post_comment'].assert_called_with(
Expand All @@ -712,7 +712,7 @@ def test_unexpected_branch_modifies_submodule(self):
)
self.mocks['modifies_submodule'].assert_called_with(self.diff)

expected_warning = """<img src="http://www.joshmatthews.net/warning.svg" alt="warning" height=20> **Warning** <img src="http://www.joshmatthews.net/warning.svg" alt="warning" height=20>
expected_warning = """:warning: **Warning** :warning:

* Pull requests are usually filed against the master branch for this repo, but this one is against something-else. Please double check that you specified the right target!
* These commits modify **submodules**."""
Expand Down