Fix and enhance next/prev message jumping.

[ehuss]

This contains a set of fixes and enhancements for the next/prev message commands:

• Sort messages so that errors show up before warnings (fixes Should jump to first error even when there are warnings #199).
• Fix next/prev when show_errors_inline is false (fixes Next Result / Previous Result (F4 / Shift + F4) don't work when "show_errors_inline" is false #206).
• Fix on-save checking when show_errors_inline is false.
• Scroll the build output panel on next/prev message.
• Next/prev now cycles through test errors.
• Fix Next/Prev overriding find-in-files next/prev (fixes Find in Files: Next Result / Previous Result shortcuts (F4 / Shift + F4) broken #209).

These changes depend on the changes in #201.

[dten]

i tried this branch cause i wasn't getting F4 etc but for me from commit 7d1ec57 I get these messages and then build says Unable to find target command: cargo_exec

I'm on windows 10 with sublime 3142

reloading plugin Rust Enhanced.cargo_build
Traceback (most recent call last):
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 109, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 915, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "C:\Users\DavidHewson\AppData\Roaming\Sublime Text 3\Packages\Rust Enhanced\cargo_build.py", line 6, in <module>
    from .rust import (rust_proc, rust_thread, opanel, util, messages,
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 915, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "C:\Users\DavidHewson\AppData\Roaming\Sublime Text 3\Packages\Rust Enhanced\rust\opanel.py", line 6, in <module>
    from . import rust_proc, messages, util
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 915, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "C:\Users\DavidHewson\AppData\Roaming\Sublime Text 3\Packages\Rust Enhanced\rust\messages.py", line 13, in <module>
    from . import util, opanel
ImportError: cannot import name opanel
reloading plugin Rust Enhanced.SyntaxCheckPlugin
Traceback (most recent call last):
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 109, in reload_plugin
    m = importlib.import_module(modulename)
  File "./python3.3/importlib/__init__.py", line 90, in import_module
  File "<frozen importlib._bootstrap>", line 1584, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1565, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1532, in _find_and_load_unlocked
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 915, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "C:\Users\DavidHewson\AppData\Roaming\Sublime Text 3\Packages\Rust Enhanced\SyntaxCheckPlugin.py", line 4, in <module>
    from .rust import (messages, rust_proc, rust_thread, util, target_detect,
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 915, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "C:\Users\DavidHewson\AppData\Roaming\Sublime Text 3\Packages\Rust Enhanced\rust\messages.py", line 13, in <module>
    from . import util, opanel
  File "C:\Program Files\Sublime Text 3\sublime_plugin.py", line 915, in load_module
    exec(compile(source, source_path, 'exec'), mod.__dict__)
  File "C:\Users\DavidHewson\AppData\Roaming\Sublime Text 3\Packages\Rust Enhanced\rust\opanel.py", line 6, in <module>
    from . import rust_proc, messages, util
ImportError: cannot import name messages

[dten]

is it cause messages imports opanel and opanel imports messages?

[dten]

i deferred the imports and it seems to be working now

[ehuss]

Thanks for taking a look at it. I guess I never restarted Sublime (and I even tested it on multiple systems). ☹️ And sorry for breaking things, I wasn't considering all the use cases. Please let me know if there are any other issues.

[dten]

Only niggle was it doesn't always show messages for test code

[ehuss]

Do you mean error messages for the on-save checking? If so, that is still blocked on rust-lang/cargo#4039.

If it is something else, can you show an example?

[ehuss]

I rebased this off master now that #201 has been merged.

[Boscop]

Any update on this?
(Jumping to errors before warnings is very important for me..)

[jasonwilliams]

Should be able to get this into the next release @Boscop