add inconceivable #1430
Merged
add inconceivable #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
inconceivable
branch
from
5c109bf to
46c49a0
Compare
|
Thanks. I'll merge tomororow in case anyone has comments. |
Shnatsel
reviewed
Sep 28, 2022
| id = "RUSTSEC-0000-0000" | ||
| package = "inconceivable" | ||
| date = "2022-09-28" | ||
| informational = "notice" |
There was a problem hiding this comment.
Perhaps informational = unsound would be more appropriate, since it allows injecting unreachable_unchecked! in safe code?
I don't have a strong opinion on this though.
There was a problem hiding this comment.
Yeah that was my first inclination, too. But plutonium is also just 'notice'.
There was a problem hiding this comment.
Yeah we decided / have precedent in the past notice for these
There was a problem hiding this comment.
btw @Shnatsel #966 (comment) also: #826 , #275
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to plutonium.