Skip to content

add inconceivable #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022
Merged

add inconceivable #1430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions crates/inconceivable/RUSTSEC-0000-0000.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "inconceivable"
date = "2022-09-28"
informational = "notice"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps informational = unsound would be more appropriate, since it allows injecting unreachable_unchecked! in safe code?

I don't have a strong opinion on this though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was my first inclination, too. But plutonium is also just 'notice'.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we decided / have precedent in the past notice for these

Copy link
Contributor

@pinkforest pinkforest Sep 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw @Shnatsel #966 (comment) also: #826 , #275

url = "https://crates.io/crates/inconceivable"

[versions]
patched = []
```

# Library exclusively intended to inject UB into safe Rust.

Quoting from the crate description:

> This crate is created purely to inject undefined behavior into stable, safe rust.

Specifically, the `inconceivable!` macro is insta-UB if the `ub_inconceivable` feature is enabled by *any* reverse dependency.
The value this adds is questionable, and hides `unsafe` code from naive analysis.