Skip to content

Braze regions server #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidbielik
Copy link
Contributor

@davidbielik davidbielik commented Feb 25, 2025

Adds new regions to braze server destinations

Testing

image
  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@davidbielik
Copy link
Contributor Author

@brennan can we get this merged please?

@brennan brennan added triaged Acknowledged by the Segment team, but not yet scheduled for review/deploy. eng-acknowledged This PR has been acknowledged by the engineering team. and removed triaged Acknowledged by the Segment team, but not yet scheduled for review/deploy. labels Mar 7, 2025
Copy link
Contributor

@marinhero marinhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davidbielik can you patch this test please? We should be good to go aftwerwards.
Screenshot 2025-03-11 at 12 37 23 PM

@davidbielik
Copy link
Contributor Author

@marinhero any suggestions on what I need to do? Tests pass for me

image

@marinhero
Copy link
Contributor

Ah! I think the test snapshot might be out of date. Let's try these instructions. Let me know how it goes!

@marinhero
Copy link
Contributor

Also, looks like this was opened right in the middle of our node 22 update. Make sure you pull the latest version of the repo so that version of the CI checks can run.

@davidbielik
Copy link
Contributor Author

davidbielik commented Mar 19, 2025

Ah! I think the test snapshot might be out of date. Let's try these instructions. Let me know how it goes!

Do you have a public link?

@marinhero
Copy link
Contributor

@marinhero
Copy link
Contributor

Hi @davidbielik, just checking in as the next deploy is scheduled for Tuesday April 8th and would be great to have this to be a part of it. LMK if you have any questions, I'll be happy to help. Best.

@davidbielik
Copy link
Contributor Author

davidbielik commented Apr 4, 2025

@marinhero I ran that command but no files change:

image

@marinhero
Copy link
Contributor

Tagging this weeks on-call to look into it @sayan-das-in

@marinhero
Copy link
Contributor

@davidbielik this appears to be a TZ issue. We either freeze the timezone within the tests or leave the prior value of the snapshot "2021-02-01". Freezing might be better for long term but keeping the old value will be a much quicker fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng-acknowledged This PR has been acknowledged by the engineering team. mode:cloud partner-eng-review (cloud) team:external
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants