Add filter query support for GemFireVectorStore #2753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Huynh <[email protected]>
jhuynh1
force-pushed
the
prefilter-gemfire-vdb
branch
from
59e9a2a to
3e713b8
Compare
|
Hi @markpollack , this is a PR for adding filter queries to GemFireVectorStore. Thanks! |
|
@jhuynh1 I am reviewing this PR. The new test in |
|
Hi, @sobychacko we have pushed a commit to the PR to fix the failing test. The failing test is passing now. Please do test it and let us know, if there is anything else we can do to get this merged. Thank you again |
nabarunnag
force-pushed
the
prefilter-gemfire-vdb
branch
2 times, most recently
from
5bd5d16 to
b2c7baa
Compare
Signed-off-by: Nabarun Nag <[email protected]>
nabarunnag
force-pushed
the
prefilter-gemfire-vdb
branch
from
b2c7baa to
2ed72a3
Compare
|
Tests are passing locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.