Skip to content

Add filter query support for GemFireVectorStore #2753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
/*
* Copyright 2023 - 2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.springframework.ai.vectorstore;

import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.List;
import java.util.TimeZone;
import java.util.regex.Pattern;

import org.springframework.ai.vectorstore.filter.Filter;
import org.springframework.ai.vectorstore.filter.Filter.Expression;
import org.springframework.ai.vectorstore.filter.Filter.Key;
import org.springframework.ai.vectorstore.filter.converter.AbstractFilterExpressionConverter;

/**
* GemFireAiSearchFilterExpressionConverter is a class that converts Filter.Expression
* objects into GemFire VectorDB query string representation. It extends the
* AbstractFilter ExpressionConverter class.
*
* @author Jason Huynh
*/
public class GemFireAiSearchFilterExpressionConverter extends AbstractFilterExpressionConverter {

private static final Pattern DATE_FORMAT_PATTERN = Pattern.compile("\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2}Z");

private final SimpleDateFormat dateFormat;

public GemFireAiSearchFilterExpressionConverter() {
this.dateFormat = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss'Z'");
this.dateFormat.setTimeZone(TimeZone.getTimeZone("UTC"));
}

@Override
protected void doExpression(Expression expression, StringBuilder context) {
if (expression.type() == Filter.ExpressionType.IN || expression.type() == Filter.ExpressionType.NIN) {
context.append(getOperationSymbol(expression));
this.convertOperand(expression.left(), context);
context.append("(");
this.convertOperand(expression.right(), context);
context.append(")");
}
else if (expression.type() == Filter.ExpressionType.GT || expression.type() == Filter.ExpressionType.GTE) {
this.convertOperand(expression.left(), context);
context.append(getOperationSymbol(expression));
this.convertOperand(expression.right(), context);
context.append(" TO *]");
}
else if (expression.type() == Filter.ExpressionType.LT || expression.type() == Filter.ExpressionType.LTE) {
this.convertOperand(expression.left(), context);
context.append("[* TO ");
this.convertOperand(expression.right(), context);
context.append(getOperationSymbol(expression));
}
else {
this.convertOperand(expression.left(), context);
context.append(getOperationSymbol(expression));
this.convertOperand(expression.right(), context);
}
}

@Override
protected void doStartValueRange(Filter.Value listValue, StringBuilder context) {
}

@Override
protected void doEndValueRange(Filter.Value listValue, StringBuilder context) {
}

@Override
protected void doAddValueRangeSpitter(Filter.Value listValue, StringBuilder context) {
context.append(" OR ");
}

private String getOperationSymbol(Expression exp) {
return switch (exp.type()) {
case AND -> " AND ";
case OR -> " OR ";
case EQ, IN -> "";
case NE -> " NOT ";
case LT -> "}";
case LTE -> "]";
case GT -> "{";
case GTE -> "[";
case NIN -> "NOT ";
default -> throw new RuntimeException("Not supported expression type: " + exp.type());
};
}

@Override
public void doKey(Key key, StringBuilder context) {
var identifier = hasOuterQuotes(key.key()) ? removeOuterQuotes(key.key()) : key.key();
context.append(identifier.trim()).append(":");
}

@Override
protected void doValue(Filter.Value filterValue, StringBuilder context) {
if (filterValue.value() instanceof List list) {
int c = 0;
for (Object v : list) {
context.append(v);
if (c++ < list.size() - 1) {
this.doAddValueRangeSpitter(filterValue, context);
}
}
}
else {
this.doSingleValue(filterValue.value(), context);
}
}

@Override
protected void doSingleValue(Object value, StringBuilder context) {
if (value instanceof Date date) {
context.append(this.dateFormat.format(date));
}
else if (value instanceof String text) {
if (DATE_FORMAT_PATTERN.matcher(text).matches()) {
try {
Date date = this.dateFormat.parse(text);
context.append(this.dateFormat.format(date));
}
catch (ParseException e) {
throw new IllegalArgumentException("Invalid date type:" + text, e);
}
}
else {
context.append(text);
}
}
else {
context.append(value);
}
}

@Override
public void doStartGroup(Filter.Group group, StringBuilder context) {
context.append("(");
}

@Override
public void doEndGroup(Filter.Group group, StringBuilder context) {
context.append(")");
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@

package org.springframework.ai.vectorstore.gemfire;

import java.util.HashMap;
import java.util.List;
import java.util.Map;

import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
Expand All @@ -28,15 +24,16 @@
import com.fasterxml.jackson.databind.json.JsonMapper;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.springframework.ai.document.Document;
import org.springframework.ai.document.DocumentMetadata;
import org.springframework.ai.embedding.EmbeddingModel;
import org.springframework.ai.embedding.EmbeddingOptionsBuilder;
import org.springframework.ai.observation.conventions.VectorStoreProvider;
import org.springframework.ai.util.JacksonUtils;
import org.springframework.ai.vectorstore.AbstractVectorStoreBuilder;
import org.springframework.ai.vectorstore.GemFireAiSearchFilterExpressionConverter;
import org.springframework.ai.vectorstore.SearchRequest;
import org.springframework.ai.vectorstore.filter.FilterExpressionConverter;
import org.springframework.ai.vectorstore.observation.AbstractObservationVectorStore;
import org.springframework.ai.vectorstore.observation.VectorStoreObservationContext;
import org.springframework.beans.factory.InitializingBean;
Expand All @@ -50,6 +47,10 @@
import org.springframework.web.reactive.function.client.WebClientResponseException;
import org.springframework.web.util.UriComponentsBuilder;

import java.util.HashMap;
import java.util.List;
import java.util.Map;

/**
* A VectorStore implementation backed by GemFire. This store supports creating, updating,
* deleting, and similarity searching of documents in a GemFire index.
Expand Down Expand Up @@ -114,6 +115,8 @@ public class GemFireVectorStore extends AbstractObservationVectorStore implement

private final String[] fields;

private final FilterExpressionConverter filterExpressionConverter;

/**
* Protected constructor that accepts a builder instance. This is the preferred way to
* create new GemFireVectorStore instances.
Expand All @@ -134,6 +137,7 @@ protected GemFireVectorStore(Builder builder) {
.build(builder.sslEnabled ? "s" : "", builder.host, builder.port)
.toString();
this.client = WebClient.create(base);
this.filterExpressionConverter = new GemFireAiSearchFilterExpressionConverter();
this.objectMapper = JsonMapper.builder().addModules(JacksonUtils.instantiateAvailableModules()).build();
}

Expand Down Expand Up @@ -245,15 +249,16 @@ public void doDelete(List<String> idList) {
@Override
@Nullable
public List<Document> doSimilaritySearch(SearchRequest request) {
String filterQuery = null;
if (request.hasFilterExpression()) {
throw new UnsupportedOperationException("GemFire currently does not support metadata filter expressions.");
filterQuery = filterExpressionConverter.convertExpression(request.getFilterExpression());
}
float[] floatVector = this.embeddingModel.embed(request.getQuery());
return this.client.post()
.uri("/" + this.indexName + QUERY)
.contentType(MediaType.APPLICATION_JSON)
.bodyValue(new QueryRequest(floatVector, request.getTopK(), request.getTopK(), // TopKPerBucket
true))
true, filterQuery))
.retrieve()
.bodyToFlux(QueryResponse.class)
.filter(r -> r.score >= request.getSimilarityThreshold())
Expand Down Expand Up @@ -474,11 +479,20 @@ private static final class QueryRequest {
@JsonProperty("include-metadata")
private final boolean includeMetadata;

@JsonProperty("filter-query")
@JsonInclude(JsonInclude.Include.NON_NULL)
private final String filterQuery;

QueryRequest(float[] vector, int k, int kPerBucket, boolean includeMetadata) {
this(vector, k, kPerBucket, includeMetadata, null);
}

QueryRequest(float[] vector, int k, int kPerBucket, boolean includeMetadata, String filterQuery) {
this.vector = vector;
this.k = k;
this.kPerBucket = kPerBucket;
this.includeMetadata = includeMetadata;
this.filterQuery = filterQuery;
}

public float[] getVector() {
Expand All @@ -497,6 +511,10 @@ public boolean isIncludeMetadata() {
return this.includeMetadata;
}

public String getFilterQuery() {
return filterQuery;
}

}

private static final class QueryResponse {
Expand Down
Loading