Skip to content

Various updates #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 23, 2025
Merged

Various updates #45

merged 16 commits into from
May 23, 2025

Conversation

lfrancke
Copy link
Member

@lfrancke lfrancke commented May 21, 2025 •
edited
Loading

Description

  • Dependency updates
  • Log open files limit
  • Reduce logging at info slightly
  • Add rust-toolchain.toml
  • Fix pre-commit warnings

hickory removed the sync mode in their 0.25 update which is why I decided to skip that update for now

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] Integration tests passed (for non trivial changes)

# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)

# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

lfrancke added 4 commits May 21, 2025 22:33
@lfrancke
Various updates
a75bff8 
- Dependency updates
- Log open files limit
- Reduce logging at info slightly
- Add rust-toolchain.toml
- Fix pre-commit warnings
@lfrancke
Various updates
9f21b92 
- Dep updates
- Rust toolchain update
- PR template update
@lfrancke
rustfmt
81d94b7
@lfrancke
Update dependencies
fdb6d25
@sbernauer
Copy link
Member

Putting this on the board for visibility as I had the exact same idea

@sbernauer sbernauer moved this to Development: In Progress in Stackable Engineering May 22, 2025
sbernauer
sbernauer reviewed May 22, 2025
View reviewed changes
@lfrancke
Copy link
Member Author

I finally managed to please my friend the pre-commit!

@lfrancke lfrancke marked this pull request as ready for review May 22, 2025 16:27
@lfrancke lfrancke moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering May 22, 2025
sbernauer
sbernauer requested changes May 23, 2025
View reviewed changes
@sbernauer sbernauer moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering May 23, 2025
@lfrancke lfrancke requested a review from sbernauer May 23, 2025 07:21
@lfrancke lfrancke enabled auto-merge May 23, 2025 07:23
@lfrancke lfrancke added this pull request to the merge queue May 23, 2025
@sbernauer sbernauer moved this from Development: In Review to Development: Done in Stackable Engineering May 23, 2025
Merged via the queue into main with commit 922b67e May 23, 2025
10 checks passed
@lfrancke lfrancke deleted the updates branch May 23, 2025 07:33
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer approved these changes

Assignees

@lfrancke lfrancke

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfrancke @sbernauer