Test: Merge IntegrationTests into Tests #8223
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
from
38c52f7 to
6132396
Compare
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
from
6132396 to
65725d0
Compare
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
from
65725d0 to
38aa16d
Compare
|
@swift-ci please test |
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
from
38aa16d to
3dad0aa
Compare
|
@swift-ci please test |
bkhouri
commented
Apr 1, 2025
| @Suite | ||
| private struct BasicTests { | ||
| @Test( | ||
| .disabled("The `swift` command line is not a swift package manager executable target"), |
There was a problem hiding this comment.
question: should we simple delete this test?
| @@ -94,6 +104,7 @@ private struct BasicTests { | |||
| } | |||
|
|
|||
| @Test( | |||
| .disabled("The `swiftc` command line is not a swift package manager executable target"), | |||
There was a problem hiding this comment.
question: Should we re-work this test so it does not rely on swiftc?
There was a problem hiding this comment.
chore (blocking): This file is not used and should be removed.
|
|
||
| public let swiftBuild: AbsolutePath = swiftpmBinaryDirectory.appending(component: "swift-build") | ||
| // public let swiftpmBinaryDirectory: AbsolutePath = { |
There was a problem hiding this comment.
chore (blocking): remove lie 111 to 127. They should be replaced with the executeSwift* functions.
|
@swift-ci please test self hosted windows |
|
@swift-ci please test windows |
This was referenced Apr 8, 2025
bkhouri
added a commit
that referenced
this pull request
Apr 9, 2025
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 10, 2025
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: swiftlang#8433 rdar://148248105 (cherry picked from commit e303b89)
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 15, 2025
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Also, to workaround a Build preset issue, add a dependency on Swift Testing when we are building using local dependencies. Related to: swiftlang#8433 rdar://148248105
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 16, 2025
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: swiftlang#8433 rdar://148248105 (cherry picked from commit e303b89)
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 16, 2025
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Also, to workaround a Build preset issue, add a dependency on Swift Testing when we are building using local dependencies. Related to: swiftlang#8433 rdar://148248105
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 16, 2025
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: swiftlang#8433 rdar://148248105
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 21, 2025
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: swiftlang#8433 rdar://148248105
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
2 times, most recently
from
f927311 to
845e74b
Compare
|
@swift-ci test |
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
from
845e74b to
a736367
Compare
|
@swift-ci test |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 29, 2025
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: swiftlang#8433 rdar://148248105
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
from
a736367 to
9253e52
Compare
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
from
9253e52 to
b02b187
Compare
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
May 13, 2025
Until swiftlang#8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: swiftlang#8433 rdar://148248105
bkhouri
added a commit
that referenced
this pull request
May 14, 2025
Until #8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: #8433 rdar://148248105 Depends on: swiftlang/swift#81401
When SwiftPM exeuctes tests using the native build system, the bundle path was failing on MacOS as the `Bundle.allBundles` did not contain the `.xctest` bundle. If we fail to find the .xctest bundle, we inspect the command line argument for the `--test-bundle-path` argument and contruct the macOS bundle root based on the argument value. In addition, convert the StaticBinaryLibraryTests to Swift Testing to validate the logic works.
Consolidate all the tests into a single folders. This change only moves the IntegrationTests/Sources and IntegrationTests/Tests to their respective directory. A subsequent change will find better homes for the tests under Tests/IntegrationTests.
… env var to have IntegrationTets pass
bkhouri
force-pushed
the
t/main/merge_integration_tests_into_tests
branch
from
b02b187 to
6898ac6
Compare
auto-merge was automatically disabled
May 16, 2025 23:02
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate all the tests into a single folders. This change only moves the IntegrationTests/Sources and IntegrationTests/Tests to their respective directory.
A subsequent change will find better homes for the tests under Tests/IntegrationTests.
Depends on: swiftlang/swift#81217
Depends on: #8685