preset: build with no assertion for swiftpm on linux #81217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift-package-manager#8223 @swift-ci smoke test |
bkhouri
force-pushed
the
t/main/swiftpm_no-assertion-on-linux
branch
from
dc7e937 to
985cef5
Compare
|
swiftlang/swift-package-manager#8223 @swift-ci smoke test |
|
swiftlang/swift-package-manager#8450 @swift-ci smoke test |
|
@swift-ci smoke test macos |
To work around swiftlang#81144, do not build swift with assertions for the SwiftPM on linux.
bkhouri
force-pushed
the
t/main/swiftpm_no-assertion-on-linux
branch
from
985cef5 to
3c363d5
Compare
|
swiftlang/swift-package-manager#8223 @swift-ci smoke test |
This was referenced May 1, 2025
|
It's not really clear to me that we want to do this 🤔 We should fix the underlying bug, I'm surprised we don't have any failing jobs for this (unless we do?) |
|
This is currently blocking SwiftPM from converting tests to Swift Testing. I completely agree we should fix the root cause, and #81144 was open to track this. But to unblock us, we opted to not build swift with assertions as the released toolchains are not. |
bkhouri
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
May 2, 2025
…g) (#8450) Convert posted test from XCTest to Swift Testing, while updating to ensuring we mark the tests that currently fail on windows. Tests/BasicsTests/FileSystem/FileSystemTests.swift Tests/BasicsTests/FileSystem/PathShimTests.swift Tests/BasicsTests/FileSystem/PathTests.swift Tests/BasicsTests/FileSystem/TemporaryFileTests.swift Tests/BasicsTests/FileSystem/VFSTests.swift Depends on swiftlang/swift#81217 Partially Addresses: #8433 Issue: rdar://148248105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work around #81144, build the Swift PM linux pseudo-toolchain without assertion