Tests: Convert StaticBinaryLibrary Test to Swift Testing #8685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SwiftPM exeuctes tests using the native build system, the bundle path was failing on MacOS as the `Bundle.allBundles` did not contain the `.xctest` bundle. If we fail to find the .xctest bundle, we inspect the command line argument for the `--test-bundle-path` argument and contruct the macOS bundle root based on the argument value. In addition, convert the StaticBinaryLibraryTests to Swift Testing to validate the logic works.
bkhouri
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
stmontgomery
approved these changes
May 16, 2025
pmattos
reviewed
May 16, 2025
| """) | ||
| } | ||
| } when: { | ||
| ProcessInfo.hostOperatingSystem == .windows |
There was a problem hiding this comment.
Question: given the whole test has issue(s) on Windows, isn't using the .disabled(if: ProcessInfo.hostOperatingSystem == .windows) trait more idiomatic here? Or just running the test on Windows provides some value?
There was a problem hiding this comment.
When the issue is fixed on Windows, this will hopefully give us signal to fix the test, by removing the withKnownIssue :)
pmattos
approved these changes
May 16, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SwiftPM executes tests using the native build system, the bundle path was failing on MacOS as the
Bundle.allBundlesdid not contain the.xctestbundle.If we fail to find the .xctest bundle, we inspect the command line argument for the
--test-bundle-pathargument and construct the macOS bundle root based on the argument value.In addition, convert the StaticBinaryLibraryTests to Swift Testing to validate the logic works.