Skip to content

feat: add context to the allowed options #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

yanick
Copy link
Collaborator

@yanick yanick commented Jan 24, 2022

For #136

Allows 'context' as one of the Svelte options.

Note that most of the changes are due to prettier and husky. (I pushed a new version with husky disabled, because the signal to noise ratio was just too bad. If the PR makes sense we can always prettierify it after the fact)

@sebastianrothe
Copy link
Collaborator

sebastianrothe commented Feb 13, 2022

Can we get this approved, please? @nickmccurdy @kentcdodds

@benmccann
Copy link
Contributor

I'm not a maintainer on this repo

@kentcdodds
Copy link
Member

I'm also not a maintainer on this package. Looks like most activity on the repo has been repo management rather than making changes to the library itself. @mihar-22 or @benmonro would probably be your best bet, but if they're not available then we'd probably need to find someone who can actively maintain this project.

Unfortunately I don't have the bandwidth for this project so I'm going to have to bow out. Good luck.

@sebastianrothe
Copy link
Collaborator

Okay, thanks for letting us know. @mihar-22 knows me from https://github.com/mihar-22/svelte-jester, already. So maybe, he can add me here as well.

@NickClark
Copy link
Collaborator

It's little disheartening to see this library stagnate so badly. Is there any movement on getting this in? Not adding support for this one option seems arbitrary and adds a decent bit of headache to workaround.

@yanick
Copy link
Collaborator Author

yanick commented Mar 15, 2022

It's little disheartening to see this library stagnate so badly. Is there any movement on getting this in? Not adding support for this one option seems arbitrary and adds a decent bit of headache to workaround.

The only thing I can think of that could help until the maintainers stir would be to fork the project and release a patched @yanick/svelte-testing-library that can be used as a stop-gap until the real project gets traction again...

@benmccann
Copy link
Contributor

@mihar-22 maybe you could weigh in or add @sebastianrothe as a maintainer?

@NickClark
Copy link
Collaborator

@yanick For now I'm using patch-package... as ugly as that is. Fix is simple enough.

@benmonro benmonro merged commit c2fc435 into testing-library:main Mar 15, 2022
@benmonro
Copy link
Member

merged, sorry gang, I don't spend much time on open source projects these days. happy to add anyone on this thread as admin who is interested as I'm no longer maintaining this.

@github-actions
Copy link

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@benmonro
Copy link
Member

@sebastianrothe @NickClark i added you both as admin, happy to add anyone else who's interested. again sorry for the delay i don't check in much on github these days

@yanick
Copy link
Collaborator Author

yanick commented Mar 15, 2022

@benmonro I'd be interested too. And no prob for the delay, that's part of the open source game. ❤️ for everything. ^.^

@benmonro
Copy link
Member

invite sent @yanick

@sebastianrothe
Copy link
Collaborator

Thanks, got it. Let's bring in some activity here :)

@yanick
Copy link
Collaborator Author

yanick commented Mar 15, 2022

Fwiw I've created #187 for the new blood to sync up. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants