chore: update everything to use try_close
#174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
added
crate/futures
davidbarsky
approved these changes
Jul 11, 2019
jonhoo
reviewed
Jul 11, 2019
jonhoo
reviewed
Jul 11, 2019
jonhoo
approved these changes
Jul 11, 2019
|
It looks like a new version of the |
|
Hmm, nightly CI build still seems to be broken, that's very odd. A clean build works locally for me. |
|
Ah, cool, apparently it's a compiler bug: serde-rs/serde#1570 (comment). I'm just going to allow the nightly build to fail for now. We can revisit that later if we want to guarantee compatibility with nightly, but in general, I think requiring the fairly unstable nightly build to pass is probably unnecessary. |
hawkw
added a commit
that referenced
this pull request
Jul 11, 2019
## Motivation Recent CI builds have failed on nightly due to a compiler bug: #174 (comment) In general, nightly Rust is unstable, and it may often fail for reasons that are not our fault. We shouldn't block merging branches on nightly failures, when they are often spurious or unrelated to `tracing`. It is, however, still good to look at these builds when possible. ## Solution This branch allows failures on `nightly` CI builds. This means that the readme-doctest build is also allowed to fail, which is a shame. It would be good to find a solution for testing readme examples that doesn't require `nightly` Rust. I have some ideas for this that I'll try to address in a subsequent branch. Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/update-world
branch
from
e5d8b93 to
945de8e
Compare
hawkw
added a commit
that referenced
this pull request
Jul 11, 2019
Recent CI builds have failed on nightly due to a compiler bug: #174 (comment) In general, nightly Rust is unstable, and it may often fail for reasons that are not our fault. We shouldn't block merging branches on nightly failures, when they are often spurious or unrelated to `tracing`. It is, however, still good to look at these builds when possible. This branch allows failures on `nightly` CI builds. This means that the readme-doctest build is also allowed to fail, which is a shame. It would be good to find a solution for testing readme examples that doesn't require `nightly` Rust. I have some ideas for this that I'll try to address in a subsequent branch. Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
force-pushed
the
eliza/update-world
branch
from
945de8e to
fc2d6ba
Compare
hawkw
added a commit
that referenced
this pull request
Jul 11, 2019
# 0.1.3 (July 11, 2019) ### Added - Log messages when a subscriber indicates that a span has closed, when the `log` feature flag is enabled (#180). ### Changed - `tracing-core` minimum dependency version to 0.1.2 (#174). ### Fixed - Fixed an issue where event macro invocations with a single field, using local variable shorthand, would recur infinitely (#166). - Fixed uses of deprecated `tracing-core` APIs (#174). Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tracing-core0.1.2 deprecated theSubscriber::drop_spanfunction infavour of
try_close.Solution
This branch updates all other crates to depend on core 0.1.2, and
replaces uses of
drop_spanwithtry_close.