RSDK-10304: Button component #363
Conversation
| const name = 'button'; | ||
|
|
||
| setUp(() async { | ||
| final port = 50000 + (name.hashCode % 10000); |
There was a problem hiding this comment.
oh, sad :( we had a helper function that did this but it sometimes led to flakey test results because of ports being already used, so it was replaced with serveServerAtUnusedPort. But, I seem to have missed the cases where we were making the port by hand here instead of calling generateTestingPortFromName. All cases of this final port = 50000 + (name.hashCode % 10000); in our tests should be replaced, though.
I'm torn on whether we should flyby fix all cases of this in this PR, or make a new ticket, so I'll defer to you on that. Either way, at a minimum I think we should definitely use serveServerAtUnusedPort here.
There was a problem hiding this comment.
done, changed it to use the same pattern as in the arm wrapper!
Oh this is an interesting question, seems to me that adding a widget would be good? but I don't feel particularly strongly |
Generated with Claude
I did not include a
ViamButtonWidgetlike in #348 but could add one if we want it