Skip to content

Fix lodash import #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

Fix lodash import #220

merged 2 commits into from
Apr 14, 2025

Conversation

j8seangel
Copy link
Contributor

For 9.1.0-beta.4 version this PR fixes:

Failed to load external module @deck.gl-community/editable-layers: SyntaxError: The requested module 'lodash' does not provide an export named 'omit'.

I also added lerna as devDependency to have the scripts running without installing it globally.

@yonghah
Copy link

yonghah commented Mar 25, 2025

Wow. This PR resolves the exact issue I am experiencing now. Thanks @j8seangel for the solution!! Hope this PR be merged soon! Thank you again!

@j8seangel
Copy link
Contributor Author

thanks @yonghah ! I hope it too
maybe @zakjan @Pessimistress or @felixpalmer can take a look?

@yeouvi29
Copy link

Thanks, @j8seangel, for fixing this issue! There is another file importing omit from lodash which is two-click-polygon-mode. Could you also include it in this PR?

@j8seangel
Copy link
Contributor Author

@yeouvi29 done! thanks for letting me know

Copy link
Collaborator

@felixpalmer felixpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! And apologies for the slow reaction

@felixpalmer felixpalmer merged commit 60aad91 into visgl:master Apr 14, 2025
1 check passed
@felixpalmer
Copy link
Collaborator

Published in v9.1.0-beta.5

@j8seangel j8seangel deleted the fix-lodash-import branch April 15, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants