Skip to content

Fix lodash import #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/editable-layers/package.json
Original file line number Diff line number Diff line change
@@ -65,6 +65,7 @@
"@types/geojson": "^7946.0.14",
"cubic-hermite-spline": "^1.0.1",
"eventemitter3": "^5.0.0",
"lodash.omit": "^4.1.1",
"lodash.throttle": "^4.1.1",
"uuid": "9.0.0",
"viewport-mercator-project": ">=6.2.3"
Original file line number Diff line number Diff line change
@@ -11,7 +11,7 @@ import {
} from './types';
import {Position, Polygon, FeatureOf, FeatureCollection} from '../utils/geojson-types';
import {GeoJsonEditMode} from './geojson-edit-mode';
import {omit} from 'lodash';
import omit from 'lodash.omit';

export class ThreeClickPolygonMode extends GeoJsonEditMode {
handleClick(event: ClickEvent, props: ModeProps<FeatureCollection>) {
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ import {
} from './types';
import {Polygon, FeatureCollection, FeatureOf, Position} from '../utils/geojson-types';
import {GeoJsonEditMode} from './geojson-edit-mode';
import {omit} from 'lodash';
import omit from 'lodash.omit';

export class TwoClickPolygonMode extends GeoJsonEditMode {
handleClick(event: ClickEvent, props: ModeProps<FeatureCollection>) {
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
@@ -49,6 +49,7 @@
"jest": "^29.2.2",
"jest-environment-jsdom": "^29.3.0",
"jsdom": "^24.0.0",
"lerna": "^8.2.0",
"ndarray": "^1.0.19",
"ndarray-pixels": "^3.1.0",
"pre-commit": "^1.2.2",
458 changes: 448 additions & 10 deletions yarn.lock

Large diffs are not rendered by default.


Unchanged files with check annotations Beta

// Copyright (c) vis.gl contributors
import {GraphLayout, GraphLayoutOptions} from '../../core/graph-layout';
import {Node} from '../../graph/node';

Check warning on line 6 in modules/graph-layers/src/layouts/experimental/radial-layout.ts

GitHub Actions / test-node

'Node' is defined but never used

Check warning on line 6 in modules/graph-layers/src/layouts/experimental/radial-layout.ts

GitHub Actions / test-node

'Node' is defined but never used
import {EDGE_TYPE} from '../../core/constants';
import {Graph} from '../../graph/graph';
[SELECTION_TYPE.RECTANGLE]: {dragToDraw: true}
};
interface SelectionLayerProps<DataT> extends CompositeLayerProps {

Check warning on line 34 in modules/editable-layers/src/editable-layers/selection-layer.ts

GitHub Actions / test-node

'DataT' is defined but never used

Check warning on line 34 in modules/editable-layers/src/editable-layers/selection-layer.ts

GitHub Actions / test-node

'DataT' is defined but never used
layerIds: any[];
onSelect: (info: any) => any;
selectionType: string | null;
const EVENT_TYPES = ['click', 'pointermove', 'panstart', 'panmove', 'panend', 'keyup'];
// TODO(v9): remove generic layer
export type EditableLayerProps<DataType = any> = CompositeLayerProps & {

Check warning on line 21 in modules/editable-layers/src/editable-layers/editable-layer.ts

GitHub Actions / test-node

'DataType' is defined but never used

Check warning on line 21 in modules/editable-layers/src/editable-layers/editable-layer.ts

GitHub Actions / test-node

'DataType' is defined but never used
pickingRadius?: number;
pickingDepth?: number;
onCancelPan?: () => void;
};
}
export function nearestPointOnLine<G extends LineString | MultiLineString>(

Check warning on line 189 in modules/editable-layers/src/edit-modes/utils.ts

GitHub Actions / test-node

'G' is defined but never used

Check warning on line 189 in modules/editable-layers/src/edit-modes/utils.ts

GitHub Actions / test-node

'G' is defined but never used
lines: FeatureOf<LineString>,
inPoint: FeatureOf<Point>,
viewport?: Viewport
delete window.__loadBingMaps;
if (moduleNames) {
Promise.all(moduleNames.map((m) => awaitCallback(namespace.loadModule, m))).then(() =>

Check warning on line 25 in modules/bing-maps/src/load-module.ts

GitHub Actions / test-node

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator

Check warning on line 25 in modules/bing-maps/src/load-module.ts

GitHub Actions / test-node

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
resolve(namespace)
);
} else {