Skip to content

Remove the confusing "not necessarily limited" part of the 1.3.4 Orientation note and expand #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2025
Merged

Remove the confusing "not necessarily limited" part of the 1.3.4 Orientation note and expand #4349

merged 3 commits into from
May 20, 2025

Conversation

patrickhlauke
Copy link
Member

Follow-up to #4348

Assuming that the here content is NOT necessarily restricted to landscape or portrait orientation relates just to the virtual reality example, this expands what was meant (at least, my understanding of it)

Closes #4346

@patrickhlauke
Remove the confusing "not necessarily limited" part of the 1.3.4 Orie…
47a20a2 
…ntation note and expand

Follow-up to #4348

Assuming that the `here content is NOT necessarily restricted to landscape or portrait orientation` relates just to the virtual reality example, this expands what was meant (at least, my understanding of it)

Closes #4346
@patrickhlauke patrickhlauke added Errata Erratum to a Recommendation Normative labels Apr 18, 2025
@patrickhlauke patrickhlauke mentioned this pull request Apr 18, 2025
Closed
@netlify Netlify
Copy link

netlify bot commented Apr 18, 2025 •
edited
Loading

✅ Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit befef67
🔍 Latest deploy log https://app.netlify.com/projects/wcag2/deploys/682c9d2c3c7b020008272c9e
😎 Deploy Preview https://deploy-preview-4349--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mbgower mbgower added ErratumRaised Potential erratum for a Recommendation Non-Normative Informative language in the specification or supporting materials and removed Errata Erratum to a Recommendation Normative labels Apr 19, 2025
@mbgower
Copy link
Contributor

mbgower commented Apr 19, 2025 •
edited
Loading

Thanks, hopefully this version will be clearer to most.

FYI, I removed the "normative" label in favour of "non-normative", which is the label we use in combination with "erratum raised" (rather than "errata") to indicate something is in the TR space, but is not normative language (notes are not normative).

patrickhlauke
patrickhlauke commented Apr 19, 2025
View reviewed changes
bruce-usab
bruce-usab approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@bruce-usab bruce-usab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VR mention is now useful! Thanks!

@mbgower mbgower merged commit a666a32 into main May 20, 2025
5 checks passed
@mbgower mbgower deleted the patrickhlauke-issue4346-orientation-clarification branch May 20, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara approved these changes

@bruce-usab bruce-usab bruce-usab approved these changes

Assignees
No one assigned
Labels
ErratumRaised Potential erratum for a Recommendation Non-Normative Informative language in the specification or supporting materials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in Success Criterion 1.3.4 Orientation Note
5 participants
@patrickhlauke @mbgower @scottaohara @GreggVan @bruce-usab