Skip to content

New version of the Web NFC specification and the Security and Privacy document. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 7, 2015

Conversation

zolkis
Copy link
Contributor

@zolkis zolkis commented Sep 5, 2015

Algorithms extended and reworked.
Changed data representation.
New security policies.
Use watches instead of events.
Fixed terminology related issues.
Renamed send() to pushMessage().
Added timeout to push options.
Issues addressed: #2, #3, #22, #26, #28, #30, #31, #32, #33, #35, #36, #38, #39, #40.
Also,
Fixed #4: use wording from [powerful features].
Fixed #29: use "in parallel" instead on "asynchronously".
Fixed #34: add example for sending data to NFC peer.
Fixed #45: add cancelPush() method.
Also, added steps on what happens with watches and push messages when focus is switched to another browsing context.

@mrj
Copy link

mrj commented Sep 6, 2015

Should NFCDeviceType be changed to NFCPushTarget?

@zolkis
Copy link
Contributor Author

zolkis commented Sep 6, 2015

We went back and forth between these two names. Perhaps NFCPushTarget is more correct.

@zolkis
Copy link
Contributor Author

zolkis commented Sep 6, 2015

Will make a new commit in this PR to fix it.

@zolkis
Copy link
Contributor Author

zolkis commented Sep 6, 2015

It seems that I have already done that and have already forgotten it :). Perhaps the comment referred to removed code (draft.idl).

@mrj
Copy link

mrj commented Sep 6, 2015

Yes, sorry, I thought draft.idl was the latest because it has the latest modification date.

@anssiko
Copy link
Member

anssiko commented Sep 7, 2015

See also the HTML diff to the latest published version.

@kenchris
Copy link
Contributor

kenchris commented Sep 7, 2015

ok lgtm

anssiko added a commit that referenced this pull request Sep 7, 2015
New version of the Web NFC specification and the Security and Privacy document.
@anssiko anssiko merged commit a193afa into w3c:gh-pages Sep 7, 2015
@anssiko
Copy link
Member

anssiko commented Sep 7, 2015

Thank you @zolkis and @kenchris. This is a significant update that addresses the open issues. I will merge this now. Couple of comments that can be addressed later:

  • In "The pushMessage algorithm", "NFCPushOptions dictionary", and "The watch() method" sections, options is undefined. You want to "Let options be ..."
  • The pushMessage algorithm is rather long (by design). If parts of it could be factored out, that might help with readability. This is just an editorial comment, however.

@zolkis
Copy link
Contributor Author

zolkis commented Sep 7, 2015

options is undefined. You want to "Let options be ..."

I thought formal parameters from the IDL don't need steps to explain their name binding.

The pushMessage algorithm is rather long (by design)

Since often the algorithm is terminated in the sub-steps, it would be cumbersome to break it out to sub-algorithms, since then it's not clear what is meta-parameter and return values and what really belongs to the algorithm. I tried that slicing e.g. with the security steps, but it became a mess.

@zolkis zolkis mentioned this pull request Sep 7, 2015
anssiko added a commit that referenced this pull request Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants