Adding supported image formats in sm-list (XCP-ng 8.3) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `xe sm-list params=all` you will now have the info of supported image formats if the SM plugin specified it in its DRIVER_INFO. The field is called `supported-image-formats`. If the plugin doesn't provide the info the field will be empty. Signed-off-by: Guillaume <[email protected]>
gthvn1
changed the title
last-genius
approved these changes
May 13, 2025
Pull Request Test Coverage Report for Build 14995750645Details
💛 - Coveralls |
|
I think that it should be a default feature for XCP-ng as XO will display this information. And it will probably be used to allow the selection of a file format when the user creates a VDI. So I think that we don't need a specific branch for this. I mean we need to provide this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the field
supported-image-formatto SM object of the XAPI database. As it modifies the database we cannot have the same patch for our 8.3 and upstream because version of XAPI database or not the same. So upstream modifications conflicts with our modification. And the branch that follows the upstream one cannot be merged without conflicts.So for testing and start review I created this patch that can be applied on our XCP-ng 8.3 branch so it is easy to test. Once reviewed I will rebase it upstream and see how we can do a PR.