api: Cut ZulipStream.canRemoveSubscribersGroup as it changes format #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a malformed-response error this is essential because it pinpoints where in the data schema the mismatch occurred between our expectations and the server's behavior. There's more to do here (zulip#890 for getting this to the user in cases like a malformed response, so they can screenshot it when reporting an issue; zulip#1083 for including stack traces when relevant in showing other errors to the user) but this is a start.
This field is becoming a group-setting value. We haven't yet implemented those (that's zulip#814), so we can no longer handle this field until we do that work. Conveniently we weren't actually making any use of this field, though -- so for now, just ignore it. Fixes: zulip#1082
This is affected by the same root cause as zulip#1082, though the impact here is much smaller: this one only applies to an event at the moment someone edits one of these settings.
|
LGTM, thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is becoming a group-setting value. We haven't yet
implemented those (that's #814), so we can no longer handle this field
until we do that work. Conveniently we weren't actually making any
use of this field, though -- so for now, just ignore it.
Fixes: #1082