[INTERNAL] Azure: Fix flaky tests on some Windows agents, set CI env variable #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to workaround for the "FATAL ERROR: v8::FromJust Maybe value is Nothing." errors we see for our Windows and macOS test executions on Azure. The error is sporadic, but most consistently appears on Windows 2022 (Azure image '20230630.1.0' and Node v18.16.1. avajs/ava#2947 seems to suggest this is a Node.js issue as reported at nodejs/node#43304 Disabling the use of our own worker threads in minifier.js resolve the issue. Disabling worker threads in AVA resolves it too. Since we want to test our worker threads, we opted for the latter by setting the AVA option '--no-worker-threads' for all scripts executed in Azure. All this indicates an issue with using worker threads (or the workerpool package) from within workers.
RandomByte
changed the title
RandomByte
changed the title
matz3
approved these changes
Jul 13, 2023
matz3
added a commit
to SAP/ui5-fs
that referenced
this pull request
Jul 13, 2023
This also solves the Node 20 issue initially addressed via #511. However, it also addresses another issue that mainly appears in the ui5-builder projects, see SAP/ui5-builder#921. Tests may run a bit slower, but more stable. JIRA: CPOUI5FOUNDATION-612
matz3
added a commit
to SAP/ui5-server
that referenced
this pull request
Jul 13, 2023
AVA's nodeArguments option doesn't seem to work with loaders on Node 20. One solution is to disable worker threads to use child processes instead. This should also stabilize test execution, especially when tests also spawn new worker threads, which mainly appeared in ui5-builder. See: SAP/ui5-fs#512 See: SAP/ui5-builder#921 JIRA: CPOUI5FOUNDATION-612
matz3
added a commit
to SAP/ui5-server
that referenced
this pull request
Jul 13, 2023
AVA's nodeArguments option doesn't seem to work with loaders on Node 20. One solution is to disable worker threads to use child processes instead. This should also stabilize test execution, especially when tests also spawn new worker threads, which mainly appeared in ui5-builder. See: SAP/ui5-fs#512 See: SAP/ui5-builder#921 JIRA: CPOUI5FOUNDATION-612
matz3
added a commit
that referenced
this pull request
Jul 13, 2023
AVA's nodeArguments option doesn't seem to work with loaders on Node 20. One solution is to disable worker threads to use child processes instead. This solution has anyways already been applied via #921 and is now enabled for all test executions. JIRA: CPOUI5FOUNDATION-612
matz3
added a commit
that referenced
this pull request
Jul 14, 2023
AVA's nodeArguments option doesn't seem to work with loaders on Node 20. One solution is to disable worker threads to use child processes instead. This solution has anyways already been applied via #921 and is now enabled for all test executions. JIRA: CPOUI5FOUNDATION-612
matz3
added a commit
to SAP/ui5-server
that referenced
this pull request
Jul 14, 2023
AVA's nodeArguments option doesn't seem to work with loaders on Node 20. One solution is to disable worker threads to use child processes instead. This should also stabilize test execution, especially when tests also spawn new worker threads, which mainly appeared in ui5-builder. See: SAP/ui5-fs#512 See: SAP/ui5-builder#921 JIRA: CPOUI5FOUNDATION-612
matz3
added a commit
to SAP/ui5-fs
that referenced
this pull request
Jul 14, 2023
This also solves the Node 20 issue initially addressed via #511. However, it also addresses another issue that mainly appears in the ui5-builder projects, see SAP/ui5-builder#921. Tests may run a bit slower, but more stable. JIRA: CPOUI5FOUNDATION-612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to workaround for the
FATAL ERROR: v8::FromJust Maybe value is Nothing.errors we see for some of our Windows and macOS test executions on Azure.The error is sporadic, but most consistently appears on Windows 2022 (Azure image '20230630.1.0' and Node v18.16.1.
avajs/ava#2947 seems to suggest this is a Node.js issue as reported at nodejs/node#43304
Disabling the use of our own worker threads in minifier.js resolve the issue. Disabling worker threads in AVA resolves it too.
Since we want to test our worker threads, we opted for the latter by setting the AVA option '--no-worker-threads' for all scripts executed in Azure.
All this indicates an issue with using worker threads (or the workerpool package) from within workers.
Also set the CI env variable for AVA to detect and make good use of.