Fix bug with renamed variable flowing into phi() node #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This was referenced Jun 20, 2025
This was referenced Jun 21, 2025
oulgen
approved these changes
Jun 21, 2025
| return acc | ||
|
|
||
| @helion.kernel(use_default_config=True) | ||
| def chebyshev_kernel(x: torch.Tensor, w: torch.Tensor) -> torch.Tensor: |
There was a problem hiding this comment.
maybe it makes sense to move this kernel to examples?
There was a problem hiding this comment.
Yeah, we could add it. Not sure if this algorithm has usages in ML, but wouldn't hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs (oldest at bottom):
Fix bug with renamed variable flowing into phi() node
Fixes #199